RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 21:47:46 +00:00
Code Issues Activity Actions

LibJS: Reorder and add missing name & length properties to Built-ins

Browse source 
The specification dicatates that each built-in will have a length and
name property. (defined in that order)
This commit is contained in:
Idan Horowitz 2021-07-08 02:49:53 +03:00 • committed by Linus Groh
parent 7e4b0681e1
commit eeb4c1eec9
16 changed files with 32 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibJS/Runtime/PromiseConstructor.cpp
View file

@ -28,8 +28,6 @@ void PromiseConstructor::initialize(GlobalObject& global_object)
// 27.2.4.4 Promise.prototype, https://tc39.es/ecma262/#sec-promise.prototype
define_direct_property(vm.names.prototype, global_object.promise_prototype(), 0);
define_direct_property(vm.names.length, Value(1), Attribute::Configurable);
u8 attr = Attribute::Writable | Attribute::Configurable;
// TODO: Implement these functions below and uncomment this.
// define_native_function(vm.names.all, all, 1, attr);
@ -40,6 +38,8 @@ void PromiseConstructor::initialize(GlobalObject& global_object)
define_native_function(vm.names.resolve, resolve, 1, attr);
define_native_accessor(*vm.well_known_symbol_species(), symbol_species_getter, {}, Attribute::Configurable);
define_direct_property(vm.names.length, Value(1), Attribute::Configurable);
}
// 27.2.3.1 Promise ( executor ), https://tc39.es/ecma262/#sec-promise-executor