RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 19:07:35 +00:00
Code Issues Activity Actions

LibJS: Reorder and add missing name & length properties to Built-ins

Browse source 
The specification dicatates that each built-in will have a length and
name property. (defined in that order)
This commit is contained in:
Idan Horowitz 2021-07-08 02:49:53 +03:00 • committed by Linus Groh
parent 7e4b0681e1
commit eeb4c1eec9
16 changed files with 32 additions and 29 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibJS/Runtime/SymbolConstructor.cpp
View file

@ -23,8 +23,6 @@ void SymbolConstructor::initialize(GlobalObject& global_object)
// 20.4.2.9 Symbol.prototype, https://tc39.es/ecma262/#sec-symbol.prototype
define_direct_property(vm.names.prototype, global_object.symbol_prototype(), 0);
define_direct_property(vm.names.length, Value(0), Attribute::Configurable);
u8 attr = Attribute::Writable | Attribute::Configurable;
define_native_function(vm.names.for_, for_, 1, attr);
define_native_function(vm.names.keyFor, key_for, 1, attr);
@ -33,6 +31,8 @@ void SymbolConstructor::initialize(GlobalObject& global_object)
define_direct_property(vm.names.SymbolName, vm.well_known_symbol_##snake_name(), 0);
JS_ENUMERATE_WELL_KNOWN_SYMBOLS
#undef __JS_ENUMERATE
define_direct_property(vm.names.length, Value(0), Attribute::Configurable);
}
SymbolConstructor::~SymbolConstructor()