From ef2469bfed7f2afff9e7da8eb9d1e4c68ca39bbd Mon Sep 17 00:00:00 2001
From: Sam Atkins <atkinssj@serenityos.org>
Date: Wed, 27 Jul 2022 11:41:31 +0100
Subject: [PATCH] LibWeb: Add missing Formatters for CSS dimension types

---
 Userland/Libraries/LibWeb/CSS/Angle.h     |  9 +++++++++
 Userland/Libraries/LibWeb/CSS/Frequency.h | 10 ++++++++++
 Userland/Libraries/LibWeb/CSS/Number.h    | 16 ++++++++++++++++
 Userland/Libraries/LibWeb/CSS/Time.h      |  9 +++++++++
 4 files changed, 44 insertions(+)

diff --git a/Userland/Libraries/LibWeb/CSS/Angle.h b/Userland/Libraries/LibWeb/CSS/Angle.h
index 9795ac2a62..ed49a80bcb 100644
--- a/Userland/Libraries/LibWeb/CSS/Angle.h
+++ b/Userland/Libraries/LibWeb/CSS/Angle.h
@@ -7,6 +7,7 @@
 #pragma once
 
 #include <AK/RefPtr.h>
+#include <AK/String.h>
 #include <LibWeb/Forward.h>
 
 namespace Web::CSS {
@@ -55,3 +56,11 @@ private:
 };
 
 }
+
+template<>
+struct AK::Formatter<Web::CSS::Angle> : Formatter<StringView> {
+    ErrorOr<void> format(FormatBuilder& builder, Web::CSS::Angle const& angle)
+    {
+        return Formatter<StringView>::format(builder, angle.to_string());
+    }
+};
diff --git a/Userland/Libraries/LibWeb/CSS/Frequency.h b/Userland/Libraries/LibWeb/CSS/Frequency.h
index c71cc67a1a..0c0c326549 100644
--- a/Userland/Libraries/LibWeb/CSS/Frequency.h
+++ b/Userland/Libraries/LibWeb/CSS/Frequency.h
@@ -7,6 +7,7 @@
 #pragma once
 
 #include <AK/RefPtr.h>
+#include <AK/String.h>
 #include <LibWeb/Forward.h>
 
 namespace Web::CSS {
@@ -50,4 +51,13 @@ private:
     float m_value { 0 };
     RefPtr<CalculatedStyleValue> m_calculated_style;
 };
+
 }
+
+template<>
+struct AK::Formatter<Web::CSS::Frequency> : Formatter<StringView> {
+    ErrorOr<void> format(FormatBuilder& builder, Web::CSS::Frequency const& frequency)
+    {
+        return Formatter<StringView>::format(builder, frequency.to_string());
+    }
+};
diff --git a/Userland/Libraries/LibWeb/CSS/Number.h b/Userland/Libraries/LibWeb/CSS/Number.h
index 3d78e28e78..feb2259f3b 100644
--- a/Userland/Libraries/LibWeb/CSS/Number.h
+++ b/Userland/Libraries/LibWeb/CSS/Number.h
@@ -6,6 +6,7 @@
 
 #pragma once
 
+#include <AK/String.h>
 #include <AK/Types.h>
 #include <math.h>
 
@@ -68,8 +69,23 @@ public:
         return { Type::Number, m_value / other.m_value };
     }
 
+    String to_string() const
+    {
+        if (m_type == Type::IntegerWithExplicitSign)
+            return String::formatted("{:+}", m_value);
+        return String::number(m_value);
+    }
+
 private:
     float m_value { 0 };
     Type m_type;
 };
 }
+
+template<>
+struct AK::Formatter<Web::CSS::Number> : Formatter<StringView> {
+    ErrorOr<void> format(FormatBuilder& builder, Web::CSS::Number const& number)
+    {
+        return Formatter<StringView>::format(builder, number.to_string());
+    }
+};
diff --git a/Userland/Libraries/LibWeb/CSS/Time.h b/Userland/Libraries/LibWeb/CSS/Time.h
index add8b692a0..1c2d1b140a 100644
--- a/Userland/Libraries/LibWeb/CSS/Time.h
+++ b/Userland/Libraries/LibWeb/CSS/Time.h
@@ -7,6 +7,7 @@
 #pragma once
 
 #include <AK/RefPtr.h>
+#include <AK/String.h>
 #include <LibWeb/Forward.h>
 
 namespace Web::CSS {
@@ -53,3 +54,11 @@ private:
 };
 
 }
+
+template<>
+struct AK::Formatter<Web::CSS::Time> : Formatter<StringView> {
+    ErrorOr<void> format(FormatBuilder& builder, Web::CSS::Time const& time)
+    {
+        return Formatter<StringView>::format(builder, time.to_string());
+    }
+};