RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 09:38:11 +00:00
Code Issues Activity Actions

Kernel: Make Inode::lookup() return a KResultOr<NonnullRefPtr<Inode>>

Browse source 
This allows file systems to return arbitrary error codes instead of just
an Inode or not an Inode.
This commit is contained in:
Andreas Kling 2021-08-14 13:32:35 +02:00
parent 459115a59c
commit ef2720bcad
18 changed files with 83 additions and 72 deletions
Download patch file Download diff file Expand all files Collapse all files

15
Kernel/FileSystem/TmpFS.cpp
View file

@ -193,19 +193,24 @@ KResultOr<size_t> TmpFSInode::write_bytes(off_t offset, size_t size, const UserO
return size;
}
RefPtr<Inode> TmpFSInode::lookup(StringView name)
KResultOr<NonnullRefPtr<Inode>> TmpFSInode::lookup(StringView name)
{
MutexLocker locker(m_inode_lock, Mutex::Mode::Shared);
VERIFY(is_directory());
if (name == ".")
return this;
if (name == "..")
return fs().get_inode(m_parent);
return *this;
if (name == "..") {
auto inode = fs().get_inode(m_parent);
// FIXME: If this cannot fail, we should probably VERIFY here instead.
if (!inode)
return ENOENT;
return inode.release_nonnull();
}
auto* child = find_child_by_name(name);
if (!child)
return {};
return ENOENT;
return child->inode;
}