RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 16:22:43 +00:00
Code Issues Activity Actions

Kernel: Mark sys$readlink() as not needing the big lock

Browse source 
This syscall doesn't access any data that was implicitly protected by
the big lock.
This commit is contained in:
Andreas Kling 2022-03-07 21:36:41 +01:00
parent 2688ee28ff
commit ef45ff4703
2 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Kernel/API/Syscall.h
View file

@ -142,7 +142,7 @@ enum class NeedsBigProcessLock {
S(purge, NeedsBigProcessLock::Yes) \ S(purge, NeedsBigProcessLock::Yes) \
S(read, NeedsBigProcessLock::Yes) \ S(read, NeedsBigProcessLock::Yes) \
S(pread, NeedsBigProcessLock::Yes) \ S(pread, NeedsBigProcessLock::Yes) \
S(readlink, NeedsBigProcessLock::Yes) \ S(readlink, NeedsBigProcessLock::No) \
S(readv, NeedsBigProcessLock::Yes) \ S(readv, NeedsBigProcessLock::Yes) \
S(realpath, NeedsBigProcessLock::No) \ S(realpath, NeedsBigProcessLock::No) \
S(recvfd, NeedsBigProcessLock::Yes) \ S(recvfd, NeedsBigProcessLock::Yes) \

2
Kernel/Syscalls/readlink.cpp
View file

@ -12,7 +12,7 @@ namespace Kernel {
ErrorOr<FlatPtr> Process::sys$readlink(Userspace<const Syscall::SC_readlink_params*> user_params) ErrorOr<FlatPtr> Process::sys$readlink(Userspace<const Syscall::SC_readlink_params*> user_params)
{ {
VERIFY_PROCESS_BIG_LOCK_ACQUIRED(this) VERIFY_NO_PROCESS_BIG_LOCK(this);
TRY(require_promise(Pledge::rpath)); TRY(require_promise(Pledge::rpath));
auto params = TRY(copy_typed_from_user(user_params)); auto params = TRY(copy_typed_from_user(user_params));