RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 14:18:12 +00:00
Code Issues Activity Actions

LibIPC: Let's start building custom message codecs for LibIPC

Browse source 
Instead of using ByteBuffer (which always malloc() their storage) for
IPC message encoding, we now use a Vector<u8, 1024>, which means that
messages smaller than 1 KB avoid heap allocation entirely.
This commit is contained in:
Andreas Kling 2019-12-30 02:41:45 +01:00
parent 00d26457c5
commit ef658594e4
3 changed files with 102 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

8
DevTools/IPCCompiler/main.cpp
View file

@ -201,6 +201,7 @@ int main(int argc, char** argv)
dbg() << "#include <AK/OwnPtr.h>";
dbg() << "#include <LibDraw/Color.h>";
dbg() << "#include <LibDraw/Rect.h>";
dbg() << "#include <LibIPC/IEncoder.h>";
dbg() << "#include <LibIPC/IEndpoint.h>";
dbg() << "#include <LibIPC/IMessage.h>";
dbg();
@ -358,11 +359,11 @@ int main(int argc, char** argv)
dbg() << " size_in_bytes = stream.offset();";
dbg() << " return make<" << name << ">(" << builder.to_string() << ");";
dbg() << " }";
dbg() << " virtual ByteBuffer encode() const override";
dbg() << " virtual IMessageBuffer encode() const override";
dbg() << " {";
// FIXME: Support longer messages:
dbg() << " auto buffer = ByteBuffer::create_uninitialized(4096);";
dbg() << " BufferStream stream(buffer);";
dbg() << " IMessageBuffer buffer;";
dbg() << " IEncoder stream(buffer);";
dbg() << " stream << endpoint_magic();";
dbg() << " stream << (int)MessageID::" << name << ";";
for (auto& parameter : parameters) {
@ -398,7 +399,6 @@ int main(int argc, char** argv)
dbg() << " stream << m_" << parameter.name << ";";
}
}
dbg() << " stream.snip();";
dbg() << " return buffer;";
dbg() << " }";
for (auto& parameter : parameters) {