From ef7f343e9518aecb47f6a4405b6bda18962f1531 Mon Sep 17 00:00:00 2001 From: Tim Schumacher Date: Thu, 2 Feb 2023 13:45:05 +0100 Subject: [PATCH] CMake: Set DWARF version before the debug information level Setting the DWARF version after having selected which level of debug information to generate apparently undoes some settings again. Doing the reverse apparently keeps both the version and the debug level setting, resulting in a significantly smaller disk image size. --- Meta/CMake/serenity_compile_options.cmake | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Meta/CMake/serenity_compile_options.cmake b/Meta/CMake/serenity_compile_options.cmake index 9ff67a17f6..603e4664e3 100644 --- a/Meta/CMake/serenity_compile_options.cmake +++ b/Meta/CMake/serenity_compile_options.cmake @@ -27,11 +27,13 @@ add_compile_options(-fsized-deallocation) add_compile_options(-fstack-clash-protection) add_compile_options(-fstack-protector-strong) add_link_options(-fstack-protector-strong) -add_compile_options(-g1) # FIXME: Remove this once DWARF revision 5 is supported add_compile_options(-gdwarf-4) +# Note: This needs to be set _after_ setting the DWARF version, otherwise we end up generating more debug information than we need. +add_compile_options(-g1) + if (CMAKE_CXX_COMPILER_ID STREQUAL "GNU") add_compile_options(-Wno-literal-suffix) add_compile_options(-Wno-maybe-uninitialized)