RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-06-19 01:02:08 +00:00
Code Issues Activity Actions

LibJS: Mark forward shape transition keys

Browse source 
These should really be weakly held by the Shape, but we don't have a
mechanism for weak hashmap keys at the moment, so let's just mark
these for now so they don't go stale.
This commit is contained in:
Andreas Kling 2023-12-11 11:18:59 +01:00
parent e5120ab389
commit ef86cf4646
1 changed files with 6 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibJS/Runtime/Shape.cpp
View file

@ -126,6 +126,12 @@ void Shape::visit_edges(Cell::Visitor& visitor)
it.key.visit_edges(visitor); it.key.visit_edges(visitor);
} }
visitor.ignore(m_prototype_transitions); visitor.ignore(m_prototype_transitions);
// FIXME: The forward transition keys should be weak, but we have to mark them for now in case they go stale.
if (m_forward_transitions) {
for (auto& it : *m_forward_transitions)
it.key.property_key.visit_edges(visitor);
}
} }
Optional<PropertyMetadata> Shape::lookup(StringOrSymbol const& property_key) const Optional<PropertyMetadata> Shape::lookup(StringOrSymbol const& property_key) const