From eff3f52bdad37d2b927bc39a414ea8f235d99bfb Mon Sep 17 00:00:00 2001 From: Fabian Dellwing Date: Fri, 14 Apr 2023 12:54:03 +0200 Subject: [PATCH] nc: Fix off-by-one-error in calls to inet_ntop --- Userland/Utilities/nc.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Userland/Utilities/nc.cpp b/Userland/Utilities/nc.cpp index 068b8a86ce..23b29f7900 100644 --- a/Userland/Utilities/nc.cpp +++ b/Userland/Utilities/nc.cpp @@ -114,7 +114,7 @@ ErrorOr serenity_main(Main::Arguments arguments) TRY(Core::System::getsockname(listen_fd, (struct sockaddr*)&sin, &len)); if (verbose) - warnln("waiting for a connection on {}:{}", inet_ntop(sin.sin_family, &sin.sin_addr, addr_str, sizeof(addr_str) - 1), ntohs(sin.sin_port)); + warnln("waiting for a connection on {}:{}", inet_ntop(sin.sin_family, &sin.sin_addr, addr_str, sizeof(addr_str)), ntohs(sin.sin_port)); } else { fd = TRY(Core::System::socket(AF_INET, SOCK_STREAM, 0)); @@ -138,7 +138,7 @@ ErrorOr serenity_main(Main::Arguments arguments) if (verbose) { char addr_str[INET_ADDRSTRLEN]; - warnln("connecting to {}:{}", inet_ntop(dst_addr.sin_family, &dst_addr.sin_addr, addr_str, sizeof(addr_str) - 1), ntohs(dst_addr.sin_port)); + warnln("connecting to {}:{}", inet_ntop(dst_addr.sin_family, &dst_addr.sin_addr, addr_str, sizeof(addr_str)), ntohs(dst_addr.sin_port)); } TRY(Core::System::connect(fd, (struct sockaddr*)&dst_addr, sizeof(dst_addr))); @@ -258,7 +258,7 @@ ErrorOr serenity_main(Main::Arguments arguments) connected_clients.set(new_client); if (verbose) - warnln("got connection from {}:{}", inet_ntop(client.sin_family, &client.sin_addr, client_str, sizeof(client_str) - 1), ntohs(client.sin_port)); + warnln("got connection from {}:{}", inet_ntop(client.sin_family, &client.sin_addr, client_str, sizeof(client_str)), ntohs(client.sin_port)); } if (has_clients) {