RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-28 09:35:09 +00:00
Code Issues Activity Actions

Spreadsheet: Use new format functions.

Browse source 
In a few places I also simplified a few format strings:

    -outln("{} item{}", items, items.size() == 1 ? ' ' : 's');
    +outln("{} item(s)", items);

In my opinion this is more readable and in some places it incorrectly
wrote '0 item' which is "fixed" now. In other places the placeholder
space looked weird.
This commit is contained in:
asynts 2020-10-06 15:02:05 +02:00 • committed by Andreas Kling
parent 30ca17e78f
commit f005548d56
5 changed files with 18 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Applications/Spreadsheet/HelpWindow.cpp
View file

@ -132,21 +132,21 @@ String HelpWindow::render(const GUI::ModelIndex& index)
markdown_builder.append("# ARGUMENTS\n");
if (argc > 0)
markdown_builder.appendf("%d required argument%s: \n", argc, argc > 1 ? "s" : "");
markdown_builder.appendff("{} required argument(s):\n", argc);
else
markdown_builder.appendf("No required arguments.\n");
for (size_t i = 0; i < argc; ++i)
markdown_builder.appendf("- `%s`\n", argnames.at(i).to_string().characters());
markdown_builder.appendff("- `{}`\n", argnames.at(i).to_string());
if (argc > 0)
markdown_builder.append("\n");
if ((size_t)argnames.size() > argc) {
auto opt_count = argnames.size() - argc;
markdown_builder.appendf("%d optional argument%s: \n", opt_count, opt_count > 1 ? "s" : "");
markdown_builder.appendff("{} optional argument(s):\n", opt_count);
for (size_t i = argc; i < (size_t)argnames.size(); ++i)
markdown_builder.appendf("- `%s`\n", argnames.at(i).to_string().characters());
markdown_builder.appendff("- `{}`\n", argnames.at(i).to_string());
markdown_builder.append("\n");
}
@ -157,7 +157,7 @@ String HelpWindow::render(const GUI::ModelIndex& index)
if (!examples.is_empty()) {
markdown_builder.append("# EXAMPLES\n");
examples.for_each_member([&](auto& text, auto& description_value) {
markdown_builder.appendf("- %s\n\n```js\n%s\n```\n", description_value.to_string().characters(), text.characters());
markdown_builder.appendf("- {}\n\n```js\n{}\n```\n", description_value.to_string(), text);
});
}