From f01cbaf5fbdbbec209fd9fce3b0df7b48be73632 Mon Sep 17 00:00:00 2001 From: Aliaksandr Kalenik Date: Wed, 13 Sep 2023 15:29:12 +0200 Subject: [PATCH] LibWeb: Remove unused `javascript:` url navigation methods in Document Those are superseded by methods to navigate `javascript:` url in navigables. --- Userland/Libraries/LibWeb/DOM/Document.cpp | 35 ---------------------- Userland/Libraries/LibWeb/DOM/Document.h | 3 -- 2 files changed, 38 deletions(-) diff --git a/Userland/Libraries/LibWeb/DOM/Document.cpp b/Userland/Libraries/LibWeb/DOM/Document.cpp index 49b7a2620e..0e18e2ac77 100644 --- a/Userland/Libraries/LibWeb/DOM/Document.cpp +++ b/Userland/Libraries/LibWeb/DOM/Document.cpp @@ -1321,41 +1321,6 @@ HTML::EnvironmentSettingsObject& Document::relevant_settings_object() const return Bindings::host_defined_environment_settings_object(realm()); } -// https://html.spec.whatwg.org/multipage/browsing-the-web.html#navigate-to-a-javascript:-url -void Document::navigate_to_javascript_url(StringView url) -{ - // FIXME: Implement the rest of steps from the spec - - // 6. Let newDocument be the result of evaluating a javascript: URL given targetNavigable, url, and initiatorOrigin. - evaluate_javascript_url(url); -} - -// https://html.spec.whatwg.org/multipage/browsing-the-web.html#evaluate-a-javascript:-url -void Document::evaluate_javascript_url(StringView url) -{ - // NOTE: This is done by EventHandler::handle_mouseup - // 1. Let urlString be the result of running the URL serializer on url. - - // 2. Let encodedScriptSource be the result of removing the leading "javascript:" from urlString. - auto encoded_script_source = url.substring_view(11, url.length() - 11); - - // FIXME: 3. Let scriptSource be the UTF-8 decoding of the percent-decoding of encodedScriptSource. - - // 4. Let settings be targetNavigable's active document's relevant settings object. - auto& settings = relevant_settings_object(); - - // 5. Let baseURL be settings's API base URL. - auto base_url = settings.api_base_url(); - - // 6. Let script be the result of creating a classic script given scriptSource, settings, baseURL, and the default classic script fetch options. - auto script = HTML::ClassicScript::create("(javascript url)", encoded_script_source, settings, base_url); - - // 7. Let evaluationStatus be the result of running the classic script script. - static_cast(script->run()); - - // FIXME: Implement the rest of the steps from the spec -} - // https://dom.spec.whatwg.org/#dom-document-createelement WebIDL::ExceptionOr> Document::create_element(String const& a_local_name, Variant const& options) { diff --git a/Userland/Libraries/LibWeb/DOM/Document.h b/Userland/Libraries/LibWeb/DOM/Document.h index 14e216d56f..3b162cc7ca 100644 --- a/Userland/Libraries/LibWeb/DOM/Document.h +++ b/Userland/Libraries/LibWeb/DOM/Document.h @@ -234,9 +234,6 @@ public: HTML::EnvironmentSettingsObject& relevant_settings_object() const; - void navigate_to_javascript_url(StringView url); - void evaluate_javascript_url(StringView url); - WebIDL::ExceptionOr> create_element(String const& local_name, Variant const& options); WebIDL::ExceptionOr> create_element_ns(Optional const& namespace_, String const& qualified_name, Variant const& options); JS::NonnullGCPtr create_document_fragment();