1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 04:27:43 +00:00

LibJS: Make Error stack trace generation faster with a line break cache

Generating Error objects got a lot slower after the introduction of
SourceCode in b0b022507b.

This was noticeable with `test-js` which generates a lot of errors,
so walking the source code over and over to compute (line, column)
was eating a ton of time.

This patch makes repeated lookups a lot faster by building a cache
of line break offsets in the source code. The cache is built on first
offset lookup, so we only pay for this in code that actually throws.

On my machine, this takes `test-js` runtime from 6.7 sec to 4.3 sec.
This commit is contained in:
Andreas Kling 2022-11-24 14:16:56 +01:00 committed by Linus Groh
parent e7ba03ddd1
commit f0482b61bf
2 changed files with 43 additions and 3 deletions

View file

@ -7,6 +7,7 @@
#pragma once
#include <AK/String.h>
#include <AK/Vector.h>
#include <LibJS/Forward.h>
namespace JS {
@ -23,8 +24,12 @@ public:
private:
SourceCode(String filename, String code);
void compute_line_break_offsets() const;
String m_filename;
String m_code;
Optional<Vector<size_t>> mutable m_line_break_offsets;
};
}