RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 10:47:35 +00:00
Code Issues Activity Actions

LibWeb: Support <svg> elements with display: block

Browse source 
There are a couple of things that went into this:

- We now calculate the intrinsic width/height and aspect ratio of <svg>
  elements based on the spec algorithm instead of our previous ad-hoc
  guesswork solution.

- Replaced elements with automatic size and intrinsic aspect ratio but
  no intrinsic dimensions are now sized with the stretch-fit width
  formula.

- We take care to assign both used width and used height to <svg>
  elements before running their SVG formatting contexts. This ensures
  that the inside SVG content is laid out with knowledge of its
  viewport geometry.

- We avoid infinite recursion in tentative_height_for_replaced_element()
  by using the already-calculated used width instead of calling the
  function that calculates the used width (since that may call us right
  back again).
This commit is contained in:
Andreas Kling 2023-05-19 18:14:37 +02:00
parent 28d2e26678
commit f0560fd087
11 changed files with 107 additions and 74 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Tests/LibWeb/Layout/input/svg/svg-intrinsic-size-in-one-dimension.html Normal file
View file

@ -0,0 +1,6 @@
<!doctype html><style>
svg {
border: 1px solid black;
display: block;
}
</style><svg viewBox="0 0 200 100" height="50"><rect x="25" y="25" width="150" height="50"></svg><svg viewBox="0 0 200 100" width="200"><rect x="25" y="25" width="150" height="50"></svg>

3
Tests/LibWeb/Layout/input/svg/svg-with-display-block.html Normal file
View file

@ -0,0 +1,3 @@
<!doctype html><style>
svg { display: block; }
</style><svg viewBox="0 0 10 10"><rect x=0 y=0 width=10 height=10></svg>