RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 07:37:35 +00:00
Code Issues Activity Actions

LibWeb: Use the spec-mandated set-value when setting an attribute

Browse source
This commit is contained in:
Timothy Flynn 2023-09-02 10:10:21 -04:00 • committed by Tim Flynn
parent 5ec76331e8
commit f05d291b41
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibWeb/DOM/Element.cpp
View file

@ -209,10 +209,10 @@ WebIDL::ExceptionOr<void> Element::set_attribute_ns(DeprecatedFlyString const& n
// 1. Let namespace, prefix, and localName be the result of passing namespace and qualifiedName to validate and extract.
auto extracted_qualified_name = TRY(validate_and_extract(realm(), namespace_, qualified_name));
// FIXME: 2. Set an attribute value for this using localName, value, and also prefix and namespace.
// 2. Set an attribute value for this using localName, value, and also prefix and namespace.
set_attribute_value(extracted_qualified_name.local_name(), value, extracted_qualified_name.prefix(), extracted_qualified_name.namespace_());
// FIXME: Don't just call through to setAttribute() here.
return set_attribute(extracted_qualified_name.local_name(), value);
return {};
}
// https://dom.spec.whatwg.org/#concept-element-attributes-set-value