From f064f5f36e6c4ec9d96122815ed359d6290f8de2 Mon Sep 17 00:00:00 2001 From: MacDue Date: Fri, 24 Feb 2023 21:03:39 +0000 Subject: [PATCH] LibDeviceTree: Propagate try_append() errors while parsing paths --- Userland/Libraries/LibDeviceTree/FlattenedDeviceTree.cpp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/Userland/Libraries/LibDeviceTree/FlattenedDeviceTree.cpp b/Userland/Libraries/LibDeviceTree/FlattenedDeviceTree.cpp index a9a5bda556..a0e6449df8 100644 --- a/Userland/Libraries/LibDeviceTree/FlattenedDeviceTree.cpp +++ b/Userland/Libraries/LibDeviceTree/FlattenedDeviceTree.cpp @@ -113,11 +113,9 @@ static ErrorOr slow_get_property_raw(StringView name, FlattenedDe // Name is a path like /path/to/node/property Vector path; TRY(name.for_each_split_view('/', SplitBehavior::Nothing, [&path](StringView view) -> ErrorOr { - if (path.size() == path.capacity()) { + if (path.size() == path.capacity()) return Error::from_errno(ENAMETOOLONG); - } - MUST(path.try_append(view)); - return {}; + return path.try_append(view); })); bool check_property_name = path.size() == 1; // Properties on root node should be checked immediately