RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 14:28:12 +00:00
Code Issues Activity Actions

WebDriver: Replace hardcoded timeout with a TimeoutsConfiguration struct

Browse source
This commit is contained in:
Linus Groh 2022-10-19 16:50:16 +02:00
parent e5a9f030f2
commit f0a8e3bc05
3 changed files with 28 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Services/WebDriver/Session.cpp
View file

@ -2,6 +2,7 @@
* Copyright (c) 2022, Florent Castelli <florent.castelli@gmail.com>
* Copyright (c) 2022, Sam Atkins <atkinssj@serenityos.org>
* Copyright (c) 2022, Tobias Christiansen <tobyase@serenityos.org>
* Copyright (c) 2022, Linus Groh <linusg@serenityos.org>
*
* SPDX-License-Identifier: BSD-2-Clause
*/
@ -265,7 +266,7 @@ static JsonObject web_element_reference_object(Session::LocalElement const& elem
ErrorOr<JsonArray, HttpError> Session::find(Session::LocalElement const& start_node, StringView const& using_, StringView const& value)
{
// 1. Let end time be the current time plus the session implicit wait timeout.
auto end_time = Core::DateTime::from_timestamp(Core::DateTime::now().timestamp() + s_session_timeouts);
auto end_time = Core::DateTime::from_timestamp(Core::DateTime::now().timestamp() + m_timeouts_configuration.implicit_wait_timeout / 1000);
// 2. Let location strategy be equal to using.
auto location_strategy = using_;