RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 12:27:35 +00:00
Code Issues Activity Actions

Everywhere: Pass AK::Format TypeErasedFormatParams by reference

Browse source 
This silences a overeager warning in sonar cloud, warning that
slicing could occur with `VariadicFormatParams` which derives from
`TypeErasedFormatParams`.

Reference:
https://sonarcloud.io/project/issues?id=SerenityOS_serenity&issues=AXuVPBO_k92xXUF3qWsm&open=AXuVPBO_k92xXUF3qWsm
This commit is contained in:
Brian Gianforcaro 2021-08-30 02:58:22 -07:00 • committed by Ali Mohammad Pur
parent 11832544e5
commit f0b3aa0331
5 changed files with 39 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/DevTools/UserspaceEmulator/Report.h
View file

@ -13,8 +13,10 @@ extern bool g_report_to_debug;
template<typename... Ts>
void reportln(const StringView& format, Ts... args)
{
if (g_report_to_debug)
AK::vdbgln(format, AK::VariadicFormatParams { args... });
else
if (g_report_to_debug) {
AK::VariadicFormatParams variadic_format_params { args... };
AK::vdbgln(format, variadic_format_params);
} else {
warnln(format, args...);
}
}