From f0b49ae04b663c7ae54ca1f3c990ab81c3bded80 Mon Sep 17 00:00:00 2001 From: Andreas Kling Date: Thu, 19 Mar 2020 11:02:20 +0100 Subject: [PATCH] LibJS: Fix reference leak in ASTNode::append() Using make like this would create an unadopted object whose refcount would never reach zero. --- Libraries/LibJS/AST.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Libraries/LibJS/AST.h b/Libraries/LibJS/AST.h index 404e376d30..7915fe7baa 100644 --- a/Libraries/LibJS/AST.h +++ b/Libraries/LibJS/AST.h @@ -87,7 +87,7 @@ public: template T& append(Args&&... args) { - auto child = make(forward(args)...); + auto child = create_ast_node(forward(args)...); m_children.append(move(child)); return static_cast(m_children.last()); }