RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 12:12:45 +00:00
Code Issues Activity Actions

LibWeb: Add missing ARIA roles to RoleType::build_role_object()

Browse source 
This change allows `contentinfo`, `none`, `subscript` and `superscript`
RoleTypes to be built. These were the only non-abstract role types
missing from this function.

This fixes an issue where clicking on an element with one of these role
types in Inspector would cause a crash.
This commit is contained in:
Tim Ledbetter 2024-01-27 17:09:33 +00:00 • committed by Tim Flynn
parent d667721b24
commit f0d2a21d77
1 changed files with 8 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibWeb/ARIA/RoleType.cpp
View file

@ -175,6 +175,8 @@ ErrorOr<NonnullOwnPtr<RoleType>> RoleType::build_role_object(Role role, bool foc
return adopt_nonnull_own_or_enomem(new (nothrow) Complementary(data));
case Role::composite:
return adopt_nonnull_own_or_enomem(new (nothrow) ContentInfo(data));
case Role::contentinfo:
return adopt_nonnull_own_or_enomem(new (nothrow) ContentInfo(data));
case Role::definition:
return adopt_nonnull_own_or_enomem(new (nothrow) Definition(data));
case Role::deletion:
@ -241,6 +243,8 @@ ErrorOr<NonnullOwnPtr<RoleType>> RoleType::build_role_object(Role role, bool foc
return adopt_nonnull_own_or_enomem(new (nothrow) MenuItemRadio(data));
case Role::navigation:
return adopt_nonnull_own_or_enomem(new (nothrow) Navigation(data));
case Role::none:
return adopt_nonnull_own_or_enomem(new (nothrow) Presentation(data));
case Role::note:
return adopt_nonnull_own_or_enomem(new (nothrow) Note(data));
case Role::option:
@ -282,6 +286,10 @@ ErrorOr<NonnullOwnPtr<RoleType>> RoleType::build_role_object(Role role, bool foc
return adopt_nonnull_own_or_enomem(new (nothrow) Status(data));
case Role::strong:
return adopt_nonnull_own_or_enomem(new (nothrow) Strong(data));
case Role::subscript:
return adopt_nonnull_own_or_enomem(new (nothrow) Subscript(data));
case Role::superscript:
return adopt_nonnull_own_or_enomem(new (nothrow) Superscript(data));
case Role::switch_:
return adopt_nonnull_own_or_enomem(new (nothrow) Switch(data));
case Role::tab: