RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 10:37:45 +00:00
Code Issues Activity Actions

LibLine: Correct weird arrow up/down behaviour

Browse source 
Fixes #3270.
Also removes a parameter from search(), as it had no effect.
This commit is contained in:
AnotherTest 2020-08-23 17:44:07 +04:30 • committed by Andreas Kling
parent 7506adbece
commit f0ef283f3c
3 changed files with 46 additions and 28 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Libraries/LibLine/Editor.h
View file

@ -300,7 +300,7 @@ private:
Style find_applicable_style(size_t offset) const;
bool search(const StringView&, bool allow_empty = false, bool from_beginning = false);
bool search(const StringView&, bool allow_empty = false);
inline void end_search()
{
m_is_searching = false;
@ -323,6 +323,8 @@ private:
m_cursor = 0;
m_drawn_cursor = 0;
m_inline_search_cursor = 0;
m_search_offset = 0;
m_search_offset_state = SearchOffsetState::Unbiased;
m_old_prompt_metrics = m_cached_prompt_metrics;
set_origin(0, 0);
m_prompt_lines_at_suggestion_initiation = 0;
@ -404,7 +406,11 @@ private:
bool m_is_searching { false };
bool m_reset_buffer_on_search_end { true };
size_t m_search_offset { 0 };
bool m_searching_backwards { true };
enum class SearchOffsetState {
Unbiased,
Backwards,
Forwards,
} m_search_offset_state { SearchOffsetState::Unbiased };
size_t m_pre_search_cursor { 0 };
Vector<u32, 1024> m_pre_search_buffer;