RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-14 16:54:57 +00:00
Code Issues Activity Actions

LibJS: Fix this_value in native setters and getters

Browse source 
This fixes getting values from double proxies:
var p = new Proxy(new Proxy([], {}), {});
p.length
This commit is contained in:
davidot 2021-06-19 14:59:32 +02:00 • committed by Linus Groh
parent 9d1fd403af
commit f102b56345
1 changed files with 3 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibJS/Runtime/Object.cpp
View file

@ -278,7 +278,7 @@ Value Object::get_own_property(const PropertyName& property_name, Value receiver
if (value_here.is_accessor())
return value_here.as_accessor().call_getter(receiver);
if (value_here.is_native_property())
return call_native_property_getter(value_here.as_native_property(), receiver);
return call_native_property_getter(value_here.as_native_property(), this);
}
return value_here;
}
@ -937,9 +937,7 @@ bool Object::put_by_index(u32 property_index, Value value)
return true;
}
if (value_here.value.is_native_property()) {
// FIXME: Why doesn't put_by_index() receive the receiver value from put()?!
auto receiver = this;
call_native_property_setter(value_here.value.as_native_property(), receiver, value);
call_native_property_setter(value_here.value.as_native_property(), this, value);
return true;
}
}
@ -976,7 +974,7 @@ bool Object::put(const PropertyName& property_name, Value value, Value receiver)
return true;
}
if (value_here.is_native_property()) {
call_native_property_setter(value_here.as_native_property(), receiver, value);
call_native_property_setter(value_here.as_native_property(), this, value);
return true;
}
}