RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-30 17:18:11 +00:00
Code Issues Activity Actions

LibWeb: Correctly handle unknown MIME types in HTMLObjectElement

Browse source 
We were using the literal string "unknown" as the unknown MIME type,
which caused us to treat the object as a nested browsing context (as
"unknown" does not start with "image/"). Use an Optional instead to
prevent this mishap.
This commit is contained in:
Timothy Flynn 2022-03-24 11:03:07 -04:00 • committed by Andreas Kling
parent c0513999d6
commit f11d6e137c
2 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/HTML/HTMLObjectElement.h
View file

@ -49,7 +49,7 @@ private:
virtual RefPtr<Layout::Node> create_layout_node(NonnullRefPtr<CSS::StyleProperties>) override;
void queue_element_task_to_run_object_representation_steps();
void run_object_representation_handler_steps(StringView resource_type);
void run_object_representation_handler_steps(Optional<String> resource_type);
void run_object_representation_completed_steps();
void run_object_representation_fallback_steps();