RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-28 19:35:09 +00:00
Code Issues Activity Actions

GTextEditor: Fix double effect of backspace/delete in some cases.

Browse source
This commit is contained in:
Andreas Kling 2019-03-07 17:18:22 +01:00
parent a738b5cb69
commit f13c62f225
1 changed files with 4 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

4
LibGUI/GTextEditor.cpp
View file

@ -213,6 +213,7 @@ void GTextEditor::keydown_event(GKeyEvent& event)
current_line().remove(m_cursor.column() - 1); current_line().remove(m_cursor.column() - 1);
update_scrollbar_ranges(); update_scrollbar_ranges();
set_cursor(m_cursor.line(), m_cursor.column() - 1); set_cursor(m_cursor.line(), m_cursor.column() - 1);
return;
} }
if (m_cursor.column() == 0 && m_cursor.line() != 0) { if (m_cursor.column() == 0 && m_cursor.line() != 0) {
// Backspace at column 0; merge with previous line // Backspace at column 0; merge with previous line
@ -223,6 +224,7 @@ void GTextEditor::keydown_event(GKeyEvent& event)
update_scrollbar_ranges(); update_scrollbar_ranges();
update(); update();
set_cursor(m_cursor.line() - 1, previous_length); set_cursor(m_cursor.line() - 1, previous_length);
return;
} }
return; return;
} }
@ -233,6 +235,7 @@ void GTextEditor::keydown_event(GKeyEvent& event)
current_line().remove(m_cursor.column()); current_line().remove(m_cursor.column());
update_scrollbar_ranges(); update_scrollbar_ranges();
update_cursor(); update_cursor();
return;
} }
if (m_cursor.column() == (current_line().length() + 1) && m_cursor.line() != line_count() - 1) { if (m_cursor.column() == (current_line().length() + 1) && m_cursor.line() != line_count() - 1) {
// Delete at end of line; merge with next line // Delete at end of line; merge with next line
@ -243,6 +246,7 @@ void GTextEditor::keydown_event(GKeyEvent& event)
update_scrollbar_ranges(); update_scrollbar_ranges();
update(); update();
set_cursor(m_cursor.line(), previous_length); set_cursor(m_cursor.line(), previous_length);
return;
} }
return; return;
} }