RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 11:57:35 +00:00
Code Issues Activity Actions

Kernel: Do not implement VERIFY_NOT_REACHED() as VERIFY(false)

Browse source 
If a switch case ends in VERIFY_NOT_REACHED(), gcc 12 thinks it might
fall through.
This commit is contained in:
Daniel Bertalan 2022-05-07 17:46:27 +02:00 • committed by Andreas Kling
parent 014b9fd709
commit f157ad8a35
1 changed files with 2 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Kernel/Assertions.h
View file

@ -18,15 +18,14 @@
__assertion_failed(#expr, __FILE__, __LINE__, __PRETTY_FUNCTION__); \ __assertion_failed(#expr, __FILE__, __LINE__, __PRETTY_FUNCTION__); \
} while (0) } while (0)
#define VERIFY_NOT_REACHED() VERIFY(false) #define VERIFY_NOT_REACHED() __assertion_failed("not reached", __FILE__, __LINE__, __PRETTY_FUNCTION__)
extern "C" { extern "C" {
[[noreturn]] void _abort(); [[noreturn]] void _abort();
[[noreturn]] void abort(); [[noreturn]] void abort();
} }
static constexpr bool TODO = false; #define TODO() __assertion_failed("TODO", __FILE__, __LINE__, __PRETTY_FUNCTION__)
#define TODO() VERIFY(TODO)
#if ARCH(I386) || ARCH(X86_64) #if ARCH(I386) || ARCH(X86_64)
# define VERIFY_INTERRUPTS_DISABLED() VERIFY(!(cpu_flags() & 0x200)) # define VERIFY_INTERRUPTS_DISABLED() VERIFY(!(cpu_flags() & 0x200))