RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 13:07:47 +00:00
Code Issues Activity Actions

Libraries: Use default constructors/destructors in LibCrypto

Browse source 
https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules

"The compiler is more likely to get the default semantics right and
you cannot implement these functions better than the compiler."
This commit is contained in:
Lenny Maiorani 2022-02-26 10:32:08 -07:00 • committed by Brian Gianforcaro
parent 59b7e6a213
commit f1c452059c
6 changed files with 11 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibCrypto/BigInt/UnsignedBigInteger.h
View file

@ -1,5 +1,6 @@
/* /*
* Copyright (c) 2020, Itamar S. <itamar8910@gmail.com> * Copyright (c) 2020, Itamar S. <itamar8910@gmail.com>
* Copyright (c) 2022, the SerenityOS developers.
* *
* SPDX-License-Identifier: BSD-2-Clause * SPDX-License-Identifier: BSD-2-Clause
*/ */
@ -31,7 +32,7 @@ public:
explicit UnsignedBigInteger(const u8* ptr, size_t length); explicit UnsignedBigInteger(const u8* ptr, size_t length);
UnsignedBigInteger() { } UnsignedBigInteger() = default;
static UnsignedBigInteger create_invalid(); static UnsignedBigInteger create_invalid();

4
Userland/Libraries/LibCrypto/Checksum/Adler32.h
View file

@ -1,5 +1,5 @@
/* /*
* Copyright (c) 2020, the SerenityOS developers. * Copyright (c) 2020-2022, the SerenityOS developers.
* *
* SPDX-License-Identifier: BSD-2-Clause * SPDX-License-Identifier: BSD-2-Clause
*/ */
@ -14,7 +14,7 @@ namespace Crypto::Checksum {
class Adler32 : public ChecksumFunction<u32> { class Adler32 : public ChecksumFunction<u32> {
public: public:
Adler32() { } Adler32() = default;
Adler32(ReadonlyBytes data) Adler32(ReadonlyBytes data)
{ {
update(data); update(data);

2
Userland/Libraries/LibCrypto/Checksum/CRC32.h
View file

@ -14,7 +14,7 @@ namespace Crypto::Checksum {
class CRC32 : public ChecksumFunction<u32> { class CRC32 : public ChecksumFunction<u32> {
public: public:
CRC32() { } CRC32() = default;
CRC32(ReadonlyBytes data) CRC32(ReadonlyBytes data)
{ {
update(data); update(data);

3
Userland/Libraries/LibCrypto/Cipher/AES.h
View file

@ -1,5 +1,6 @@
/* /*
* Copyright (c) 2020, Ali Mohammad Pur <mpfard@serenityos.org> * Copyright (c) 2020, Ali Mohammad Pur <mpfard@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
* *
* SPDX-License-Identifier: BSD-2-Clause * SPDX-License-Identifier: BSD-2-Clause
*/ */
@ -81,7 +82,7 @@ struct AESCipherKey : public CipherKey {
expand_decrypt_key(user_key, key_bits); expand_decrypt_key(user_key, key_bits);
} }
virtual ~AESCipherKey() override { } virtual ~AESCipherKey() override = default;
size_t rounds() const { return m_rounds; } size_t rounds() const { return m_rounds; }
size_t length() const { return m_bits / 8; } size_t length() const { return m_bits / 8; }

3
Userland/Libraries/LibCrypto/Cipher/Cipher.h
View file

@ -1,5 +1,6 @@
/* /*
* Copyright (c) 2020, Ali Mohammad Pur <mpfard@serenityos.org> * Copyright (c) 2020, Ali Mohammad Pur <mpfard@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
* *
* SPDX-License-Identifier: BSD-2-Clause * SPDX-License-Identifier: BSD-2-Clause
*/ */
@ -82,7 +83,7 @@ struct CipherKey {
virtual ReadonlyBytes bytes() const = 0; virtual ReadonlyBytes bytes() const = 0;
static bool is_valid_key_size(size_t) { return false; }; static bool is_valid_key_size(size_t) { return false; };
virtual ~CipherKey() { } virtual ~CipherKey() = default;
protected: protected:
virtual void expand_encrypt_key(ReadonlyBytes user_key, size_t bits) = 0; virtual void expand_encrypt_key(ReadonlyBytes user_key, size_t bits) = 0;

3
Userland/Libraries/LibCrypto/PK/RSA.h
View file

@ -1,5 +1,6 @@
/* /*
* Copyright (c) 2020, Ali Mohammad Pur <mpfard@serenityos.org> * Copyright (c) 2020, Ali Mohammad Pur <mpfard@serenityos.org>
* Copyright (c) 2022, the SerenityOS developers.
* *
* SPDX-License-Identifier: BSD-2-Clause * SPDX-License-Identifier: BSD-2-Clause
*/ */
@ -204,7 +205,7 @@ public:
{ {
} }
~RSA_PKCS1_EME() { } ~RSA_PKCS1_EME() = default;
virtual void encrypt(ReadonlyBytes in, Bytes& out) override; virtual void encrypt(ReadonlyBytes in, Bytes& out) override;
virtual void decrypt(ReadonlyBytes in, Bytes& out) override; virtual void decrypt(ReadonlyBytes in, Bytes& out) override;