RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 12:57:34 +00:00
Code Issues Activity Actions

AK: Add unit tests to verify AK::InstrusiveList<T> holding RefPtr<T>

Browse source 
Validate that the refcounting works as expected, and continues to work.
This commit is contained in:
Brian Gianforcaro 2021-04-19 23:31:53 -07:00 • committed by Linus Groh
parent 93e5ba2347
commit f1d832e5ea
1 changed files with 78 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

84
AK/Tests/TestIntrusiveList.cpp
View file

@ -24,19 +24,16 @@
* OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
*/ */
#include <AK/TestSuite.h>
#include <AK/IntrusiveList.h> #include <AK/IntrusiveList.h>
#include <AK/NonnullOwnPtrVector.h> #include <AK/NonnullOwnPtr.h>
#include <AK/Random.h> #include <AK/RefPtr.h>
#include <AK/TestSuite.h>
class IntrusiveTestItem { class IntrusiveTestItem {
public: public:
IntrusiveTestItem() = default; IntrusiveTestItem() = default;
IntrusiveListNode<IntrusiveTestItem> m_list_node; IntrusiveListNode<IntrusiveTestItem> m_list_node;
}; };
using IntrusiveTestList = IntrusiveList<IntrusiveTestItem, RawPtr<IntrusiveTestItem>, &IntrusiveTestItem::m_list_node>; using IntrusiveTestList = IntrusiveList<IntrusiveTestItem, RawPtr<IntrusiveTestItem>, &IntrusiveTestItem::m_list_node>;
TEST_CASE(construct) TEST_CASE(construct)
@ -65,6 +62,7 @@ TEST_CASE(enumeration)
size_t actual_size = 0; size_t actual_size = 0;
for (auto& elem : list) { for (auto& elem : list) {
(void)elem;
actual_size++; actual_size++;
} }
EXPECT_EQ(expected_size, actual_size); EXPECT_EQ(expected_size, actual_size);
@ -73,4 +71,78 @@ TEST_CASE(enumeration)
} }
} }
class IntrusiveRefPtrItem : public RefCounted<IntrusiveRefPtrItem> {
public:
IntrusiveRefPtrItem() = default;
IntrusiveListNode<IntrusiveRefPtrItem, RefPtr<IntrusiveRefPtrItem>> m_list_node;
};
using IntrusiveRefPtrList = IntrusiveList<IntrusiveRefPtrItem, RefPtr<IntrusiveRefPtrItem>, &IntrusiveRefPtrItem::m_list_node>;
TEST_CASE(intrusive_ref_ptr_no_ref_leaks)
{
auto item = adopt(*new IntrusiveRefPtrItem());
EXPECT_EQ(1u, item->ref_count());
IntrusiveRefPtrList ref_list;
ref_list.append(*item);
EXPECT_EQ(2u, item->ref_count());
ref_list.remove(*item);
EXPECT_EQ(1u, item->ref_count());
}
TEST_CASE(intrusive_ref_ptr_clear)
{
auto item = adopt(*new IntrusiveRefPtrItem());
EXPECT_EQ(1u, item->ref_count());
IntrusiveRefPtrList ref_list;
ref_list.append(*item);
EXPECT_EQ(2u, item->ref_count());
ref_list.clear();
EXPECT_EQ(1u, item->ref_count());
}
TEST_CASE(intrusive_ref_ptr_destructor)
{
auto item = adopt(*new IntrusiveRefPtrItem());
EXPECT_EQ(1u, item->ref_count());
{
IntrusiveRefPtrList ref_list;
ref_list.append(*item);
EXPECT_EQ(2u, item->ref_count());
}
EXPECT_EQ(1u, item->ref_count());
}
// There is currently a bug in the NonnullRefPtr specialization of IntrusiveList,
// so this test fails to compile at the moment. Including it for future use.
#if 0
class IntrusiveNonnullRefPtrItem : public RefCounted<IntrusiveNonnullRefPtrItem> {
public:
IntrusiveNonnullRefPtrItem() = default;
IntrusiveListNode<IntrusiveNonnullRefPtrItem, NonnullRefPtr<IntrusiveNonnullRefPtrItem>> m_list_node;
};
using IntrusiveNonnullRefPtrList = IntrusiveList<IntrusiveNonnullRefPtrItem, NonnullRefPtr<IntrusiveNonnullRefPtrItem>, &IntrusiveNonnullRefPtrItem::m_list_node>;
TEST_CASE(intrusive_nonnull_ref_ptr_intrusive)
{
auto item = adopt(*new IntrusiveNonnullRefPtrItem());
EXPECT_EQ(1u, item->ref_count());
IntrusiveNonnullRefPtrList nonnull_ref_list;
nonnull_ref_list.append(*item);
EXPECT_EQ(2u, item->ref_count());
EXPECT(!nonnull_ref_list.is_empty());
nonnull_ref_list.remove(*item);
EXPECT_EQ(1u, item->ref_count());
EXPECT(nonnull_ref_list.is_empty());
}
#endif
TEST_MAIN(IntrusiveList) TEST_MAIN(IntrusiveList)