diff --git a/Userland/Applications/MouseSettings/CMakeLists.txt b/Userland/Applications/MouseSettings/CMakeLists.txt index a266dd7be3..586f5cb6ff 100644 --- a/Userland/Applications/MouseSettings/CMakeLists.txt +++ b/Userland/Applications/MouseSettings/CMakeLists.txt @@ -10,7 +10,6 @@ compile_gml(Theme.gml ThemeWidgetGML.h theme_widget_gml) set(SOURCES main.cpp DoubleClickArrowWidget.cpp - MouseSettingsWindow.cpp MouseWidget.cpp MouseWidget.h MouseWidgetGML.h diff --git a/Userland/Applications/MouseSettings/MouseSettingsWindow.cpp b/Userland/Applications/MouseSettings/MouseSettingsWindow.cpp deleted file mode 100644 index c0a7ba7db9..0000000000 --- a/Userland/Applications/MouseSettings/MouseSettingsWindow.cpp +++ /dev/null @@ -1,68 +0,0 @@ -/* - * Copyright (c) 2020, Idan Horowitz - * Copyright (c) 2021, the SerenityOS developers. - * Copyright (c) 2021, Andreas Kling - * - * SPDX-License-Identifier: BSD-2-Clause - */ - -#include "MouseSettingsWindow.h" -#include "MouseWidget.h" -#include "ThemeWidget.h" -#include -#include -#include -#include -#include - -MouseSettingsWindow::MouseSettingsWindow() -{ - auto& main_widget = set_main_widget(); - main_widget.set_fill_with_background_color(true); - main_widget.set_layout(); - main_widget.layout()->set_margins(4); - main_widget.layout()->set_spacing(6); - - auto& tab_widget = main_widget.add(); - - auto& mouse_widget = tab_widget.add_tab("Mouse"); - auto& theme_widget = tab_widget.add_tab("Cursor Theme"); - - auto& button_container = main_widget.add(); - button_container.set_shrink_to_fit(true); - button_container.set_layout(); - button_container.layout()->set_spacing(6); - - m_reset_button = button_container.add("Defaults"); - m_reset_button->on_click = [&](auto) { - mouse_widget.reset_default_values(); - theme_widget.reset_default_values(); - }; - - button_container.layout()->add_spacer(); - - m_ok_button = button_container.add("OK"); - m_ok_button->set_fixed_width(75); - m_ok_button->on_click = [&](auto) { - mouse_widget.update_window_server(); - theme_widget.update_window_server(); - GUI::Application::the()->quit(); - }; - - m_cancel_button = button_container.add("Cancel"); - m_cancel_button->set_fixed_width(75); - m_cancel_button->on_click = [&](auto) { - GUI::Application::the()->quit(); - }; - - m_apply_button = button_container.add("Apply"); - m_apply_button->set_fixed_width(75); - m_apply_button->on_click = [&](auto) { - mouse_widget.update_window_server(); - theme_widget.update_window_server(); - }; -} - -MouseSettingsWindow::~MouseSettingsWindow() -{ -} diff --git a/Userland/Applications/MouseSettings/MouseSettingsWindow.h b/Userland/Applications/MouseSettings/MouseSettingsWindow.h deleted file mode 100644 index 3c45d7a96d..0000000000 --- a/Userland/Applications/MouseSettings/MouseSettingsWindow.h +++ /dev/null @@ -1,25 +0,0 @@ -/* - * Copyright (c) 2020, Idan Horowitz - * Copyright (c) 2021, the SerenityOS developers. - * - * SPDX-License-Identifier: BSD-2-Clause - */ - -#pragma once - -#include -#include - -class MouseSettingsWindow final : public GUI::Window { - C_OBJECT(MouseSettingsWindow) -public: - virtual ~MouseSettingsWindow() override; - -private: - MouseSettingsWindow(); - - RefPtr m_ok_button; - RefPtr m_cancel_button; - RefPtr m_apply_button; - RefPtr m_reset_button; -}; diff --git a/Userland/Applications/MouseSettings/MouseWidget.cpp b/Userland/Applications/MouseSettings/MouseWidget.cpp index 0816f0bb33..865a4cf3d4 100644 --- a/Userland/Applications/MouseSettings/MouseWidget.cpp +++ b/Userland/Applications/MouseSettings/MouseWidget.cpp @@ -57,7 +57,7 @@ MouseWidget::MouseWidget() switch_buttons_image_label.set_icon(Gfx::Bitmap::try_load_from_file("/res/graphics/switch-mouse-buttons.png").release_value_but_fixme_should_propagate_errors()); } -void MouseWidget::update_window_server() +void MouseWidget::apply_settings() { float const factor = m_speed_slider->value() / speed_slider_scale; GUI::WindowServerConnection::the().async_set_mouse_acceleration(factor); @@ -72,7 +72,6 @@ void MouseWidget::reset_default_values() m_scroll_length_spinbox->set_value(default_scroll_length); m_double_click_speed_slider->set_value(double_click_speed_default); m_switch_buttons_checkbox->set_checked(false); - update_window_server(); } MouseWidget::~MouseWidget() diff --git a/Userland/Applications/MouseSettings/MouseWidget.h b/Userland/Applications/MouseSettings/MouseWidget.h index 967709ae9f..ab9181d9fd 100644 --- a/Userland/Applications/MouseSettings/MouseWidget.h +++ b/Userland/Applications/MouseSettings/MouseWidget.h @@ -6,18 +6,18 @@ #pragma once +#include "DoubleClickArrowWidget.h" #include +#include #include -#include "DoubleClickArrowWidget.h" - -class MouseWidget final : public GUI::Widget { +class MouseWidget final : public GUI::SettingsWindow::Tab { C_OBJECT(MouseWidget) public: virtual ~MouseWidget() override; - void update_window_server(); - void reset_default_values(); + virtual void apply_settings() override; + virtual void reset_default_values() override; private: MouseWidget(); diff --git a/Userland/Applications/MouseSettings/ThemeWidget.cpp b/Userland/Applications/MouseSettings/ThemeWidget.cpp index cb7b498881..1589e9baad 100644 --- a/Userland/Applications/MouseSettings/ThemeWidget.cpp +++ b/Userland/Applications/MouseSettings/ThemeWidget.cpp @@ -6,6 +6,7 @@ #include "ThemeWidget.h" +#include #include #include #include @@ -127,7 +128,7 @@ ThemeWidget::ThemeWidget() m_theme_name_box->set_text(m_theme_name); } -void ThemeWidget::update_window_server() +void ThemeWidget::apply_settings() { GUI::WindowServerConnection::the().async_apply_cursor_theme(m_theme_name_box->text()); } @@ -135,7 +136,6 @@ void ThemeWidget::update_window_server() void ThemeWidget::reset_default_values() { m_theme_name_box->set_text("Default"); - update_window_server(); } ThemeWidget::~ThemeWidget() diff --git a/Userland/Applications/MouseSettings/ThemeWidget.h b/Userland/Applications/MouseSettings/ThemeWidget.h index 58c64af07c..5e54ce1f05 100644 --- a/Userland/Applications/MouseSettings/ThemeWidget.h +++ b/Userland/Applications/MouseSettings/ThemeWidget.h @@ -6,13 +6,10 @@ #pragma once -#include -#include -#include -#include - #include "DoubleClickArrowWidget.h" -#include "LibGUI/FilePicker.h" +#include +#include +#include class MouseCursorModel final : public GUI::Model { public: @@ -65,13 +62,13 @@ private: Vector m_themes; }; -class ThemeWidget final : public GUI::Widget { +class ThemeWidget final : public GUI::SettingsWindow::Tab { C_OBJECT(ThemeWidget) public: virtual ~ThemeWidget() override; - void update_window_server(); - void reset_default_values(); + virtual void apply_settings() override; + virtual void reset_default_values() override; private: ThemeWidget(); diff --git a/Userland/Applications/MouseSettings/main.cpp b/Userland/Applications/MouseSettings/main.cpp index 4ca4e05f91..9a906c331c 100644 --- a/Userland/Applications/MouseSettings/main.cpp +++ b/Userland/Applications/MouseSettings/main.cpp @@ -2,14 +2,17 @@ * Copyright (c) 2020, Idan Horowitz * Copyright (c) 2021, the SerenityOS developers. * Copyright (c) 2021, Andreas Kling + * Copyright (c) 2021, Sam Atkins * * SPDX-License-Identifier: BSD-2-Clause */ -#include "MouseSettingsWindow.h" +#include "MouseWidget.h" +#include "ThemeWidget.h" #include #include #include +#include #include int main(int argc, char** argv) @@ -28,11 +31,9 @@ int main(int argc, char** argv) auto app_icon = GUI::Icon::default_icon("app-mouse"); - auto window = MouseSettingsWindow::construct(); - window->set_title("Mouse Settings"); - window->resize(400, 480); - window->set_resizable(false); - window->set_minimizable(false); + auto window = GUI::SettingsWindow::construct("Mouse Settings", GUI::SettingsWindow::ShowDefaultsButton::Yes); + window->add_tab("Mouse"); + window->add_tab("Cursor Theme"); window->set_icon(app_icon.bitmap_for_size(16)); window->show();