RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-06-01 02:38:13 +00:00
Code Issues Activity Actions

LibELF: Move DynamicObject::lookup_symbol() to DynamicLoader

Browse source 
Also simplify it by removing an unreachable code path.
This commit is contained in:
Andreas Kling 2021-02-21 00:29:08 +01:00
parent a43910acc3
commit f23b29f605
4 changed files with 14 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibELF/DynamicLoader.h
View file

@ -71,6 +71,8 @@ public:
VirtualAddress text_segment_load_address() const { return m_text_segment_load_address; }
bool is_dynamic() const { return m_elf_image.is_dynamic(); }
static Optional<DynamicObject::SymbolLookupResult> lookup_symbol(const ELF::DynamicObject::Symbol&);
private:
DynamicLoader(int fd, String filename, void* file_data, size_t file_size);
@ -121,8 +123,6 @@ private:
RelocationResult do_relocation(size_t total_tls_size, const DynamicObject::Relocation&);
size_t calculate_tls_size() const;
Optional<DynamicObject::SymbolLookupResult> lookup_symbol(const ELF::DynamicObject::Symbol&) const;
String m_filename;
String m_program_interpreter;
size_t m_file_size { 0 };