RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 07:37:44 +00:00
Code Issues Activity Actions

AK: Ignore whitespace while decoding base64

Browse source 
This matches how other implementations behave.

1% progression on ACID3. :^)
This commit is contained in:
Andreas Kling 2022-02-25 19:35:51 +01:00
parent 17f34488f6
commit f2663f477f
3 changed files with 38 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

17
Tests/AK/TestURL.cpp
View file

@ -1,5 +1,5 @@
/*
* Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2018-2022, Andreas Kling <kling@serenityos.org>
* Copyright (c) 2021, the SerenityOS developers.
*
* SPDX-License-Identifier: BSD-2-Clause
@ -7,6 +7,7 @@
#include <LibTest/TestCase.h>
#include <AK/Base64.h>
#include <AK/URL.h>
TEST_CASE(construct)
@ -280,6 +281,20 @@ TEST_CASE(data_url_base64_encoded_with_whitespace)
EXPECT_EQ(url.serialize(), "data:text/html;base64, test with whitespace ");
}
TEST_CASE(data_url_base64_encoded_with_inline_whitespace)
{
URL url("data:text/javascript;base64,%20ZD%20Qg%0D%0APS%20An%20Zm91cic%0D%0A%207%20");
EXPECT(url.is_valid());
EXPECT_EQ(url.scheme(), "data");
EXPECT(url.host().is_null());
EXPECT_EQ(url.data_mime_type(), "text/javascript");
EXPECT(url.data_payload_is_base64());
EXPECT_EQ(url.data_payload(), " ZD Qg\r\nPS An Zm91cic\r\n 7 "sv);
auto decode_result = decode_base64(url.data_payload());
EXPECT_EQ(decode_result.is_error(), false);
EXPECT_EQ(StringView(decode_result.value()), "d4 = 'four';"sv);
}
TEST_CASE(trailing_slash_with_complete_url)
{
EXPECT_EQ(URL("http://a/b/").complete_url("c/").serialize(), "http://a/b/c/");