From f268a9122788b57edb4a42e3cad723b534672dd4 Mon Sep 17 00:00:00 2001 From: Lenny Maiorani Date: Wed, 23 Mar 2022 21:18:10 -0600 Subject: [PATCH] Utilities: Use default constructors/destructors https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules "The compiler is more likely to get the default semantics right and you cannot implement these functions better than the compiler." --- Userland/Utilities/expr.cpp | 4 ++-- Userland/Utilities/find.cpp | 2 +- Userland/Utilities/test.cpp | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Userland/Utilities/expr.cpp b/Userland/Utilities/expr.cpp index f31ab94acf..a16d552f49 100644 --- a/Userland/Utilities/expr.cpp +++ b/Userland/Utilities/expr.cpp @@ -58,7 +58,7 @@ public: virtual int integer() const = 0; virtual String string() const = 0; virtual Type type() const = 0; - virtual ~Expression() { } + virtual ~Expression() = default; }; class ValueExpression : public Expression { @@ -75,7 +75,7 @@ public: { } - virtual ~ValueExpression() { } + virtual ~ValueExpression() {}; private: virtual bool truth() const override diff --git a/Userland/Utilities/find.cpp b/Userland/Utilities/find.cpp index 8314198466..aee5d9544c 100644 --- a/Userland/Utilities/find.cpp +++ b/Userland/Utilities/find.cpp @@ -90,7 +90,7 @@ struct FileData { class Command { public: - virtual ~Command() { } + virtual ~Command() = default; virtual bool evaluate(FileData& file_data) const = 0; }; diff --git a/Userland/Utilities/test.cpp b/Userland/Utilities/test.cpp index ef5f79f307..2590787da7 100644 --- a/Userland/Utilities/test.cpp +++ b/Userland/Utilities/test.cpp @@ -30,7 +30,7 @@ bool g_there_was_an_error = false; class Condition { public: - virtual ~Condition() { } + virtual ~Condition() = default; virtual bool check() const = 0; };