From f27e76b0b7819d5ac70da9ce61c3a1bc86b9ca9c Mon Sep 17 00:00:00 2001 From: Shannon Booth Date: Sun, 19 Nov 2023 11:44:29 +1300 Subject: [PATCH] LibWeb: Make ReadableStreamAddReadRequest take a NonnullGCPtr Make it more obvious in the function signature that this function will be taking a GC ref to a ReadRequest by appending it to the ReadableStreams pending read requests. --- Userland/Libraries/LibWeb/Streams/AbstractOperations.cpp | 2 +- Userland/Libraries/LibWeb/Streams/AbstractOperations.h | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Userland/Libraries/LibWeb/Streams/AbstractOperations.cpp b/Userland/Libraries/LibWeb/Streams/AbstractOperations.cpp index d7fe66e8ba..470d25d165 100644 --- a/Userland/Libraries/LibWeb/Streams/AbstractOperations.cpp +++ b/Userland/Libraries/LibWeb/Streams/AbstractOperations.cpp @@ -346,7 +346,7 @@ void readable_stream_error(ReadableStream& stream, JS::Value error) } // https://streams.spec.whatwg.org/#readable-stream-add-read-request -void readable_stream_add_read_request(ReadableStream& stream, ReadRequest& read_request) +void readable_stream_add_read_request(ReadableStream& stream, JS::NonnullGCPtr read_request) { // 1. Assert: stream.[[reader]] implements ReadableStreamDefaultReader. VERIFY(stream.reader().has_value() && stream.reader()->has>()); diff --git a/Userland/Libraries/LibWeb/Streams/AbstractOperations.h b/Userland/Libraries/LibWeb/Streams/AbstractOperations.h index 4e03e6cd80..3485003be8 100644 --- a/Userland/Libraries/LibWeb/Streams/AbstractOperations.h +++ b/Userland/Libraries/LibWeb/Streams/AbstractOperations.h @@ -37,7 +37,7 @@ WebIDL::ExceptionOr extract_high_water_mark(QueuingStrategy const&, doub void readable_stream_close(ReadableStream&); void readable_stream_error(ReadableStream&, JS::Value error); -void readable_stream_add_read_request(ReadableStream&, ReadRequest&); +void readable_stream_add_read_request(ReadableStream&, JS::NonnullGCPtr); WebIDL::ExceptionOr> readable_stream_cancel(ReadableStream&, JS::Value reason); void readable_stream_fulfill_read_into_request(ReadableStream&, JS::Value chunk, bool done); void readable_stream_fulfill_read_request(ReadableStream&, JS::Value chunk, bool done);