RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 09:37:44 +00:00
Code Issues Activity Actions

Userland: Disambiguate dependent types

Browse source 
Clang produced an error on these pieces of code without the `typename`
keyword.
This commit is contained in:
Daniel Bertalan 2021-06-20 21:10:54 +02:00 • committed by Ali Mohammad Pur
parent f820917a76
commit f28f00c654
3 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibIPC/ClientConnection.h
View file

@ -22,7 +22,7 @@ class ClientConnection : public Connection<ServerEndpoint, ClientEndpoint>
, public ClientEndpoint::template Proxy<ServerEndpoint> { , public ClientEndpoint::template Proxy<ServerEndpoint> {
public: public:
using ServerStub = typename ServerEndpoint::Stub; using ServerStub = typename ServerEndpoint::Stub;
using IPCProxy = ClientEndpoint::template Proxy<ServerEndpoint>; using IPCProxy = typename ClientEndpoint::template Proxy<ServerEndpoint>;
ClientConnection(ServerStub& stub, NonnullRefPtr<Core::LocalSocket> socket, int client_id) ClientConnection(ServerStub& stub, NonnullRefPtr<Core::LocalSocket> socket, int client_id)
: IPC::Connection<ServerEndpoint, ClientEndpoint>(stub, move(socket)) : IPC::Connection<ServerEndpoint, ClientEndpoint>(stub, move(socket))

2
Userland/Libraries/LibIPC/ServerConnection.h
View file

@ -16,7 +16,7 @@ class ServerConnection : public IPC::Connection<ClientEndpoint, ServerEndpoint>
, public ServerEndpoint::template Proxy<ClientEndpoint> { , public ServerEndpoint::template Proxy<ClientEndpoint> {
public: public:
using ClientStub = typename ClientEndpoint::Stub; using ClientStub = typename ClientEndpoint::Stub;
using IPCProxy = ServerEndpoint::template Proxy<ClientEndpoint>; using IPCProxy = typename ServerEndpoint::template Proxy<ClientEndpoint>;
ServerConnection(ClientStub& local_endpoint, const StringView& address) ServerConnection(ClientStub& local_endpoint, const StringView& address)
: Connection<ClientEndpoint, ServerEndpoint>(local_endpoint, Core::LocalSocket::construct()) : Connection<ClientEndpoint, ServerEndpoint>(local_endpoint, Core::LocalSocket::construct())

4
Userland/Services/RequestServer/HttpCommon.h
View file

@ -55,8 +55,8 @@ void init(TSelf* self, TJob job)
template<typename TBadgedProtocol, typename TPipeResult> template<typename TBadgedProtocol, typename TPipeResult>
OwnPtr<Request> start_request(TBadgedProtocol&& protocol, ClientConnection& client, const String& method, const URL& url, const HashMap<String, String>& headers, ReadonlyBytes body, TPipeResult&& pipe_result) OwnPtr<Request> start_request(TBadgedProtocol&& protocol, ClientConnection& client, const String& method, const URL& url, const HashMap<String, String>& headers, ReadonlyBytes body, TPipeResult&& pipe_result)
{ {
using TJob = TBadgedProtocol::Type::JobType; using TJob = typename TBadgedProtocol::Type::JobType;
using TRequest = TBadgedProtocol::Type::RequestType; using TRequest = typename TBadgedProtocol::Type::RequestType;
if (pipe_result.is_error()) { if (pipe_result.is_error()) {
return {}; return {};