From f2c1130f23e75c7ec43dc88183ffb04189621919 Mon Sep 17 00:00:00 2001 From: Kemal Zebari Date: Fri, 12 Jan 2024 17:00:56 -0800 Subject: [PATCH] LibWeb/MimeSniff: Remove unnecessary addition in mp4 signature match A little whoopsie I did not see in 3aaa1c1. This is not erroneous behavior, but it's just not necessary. --- Userland/Libraries/LibWeb/MimeSniff/Resource.cpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/Userland/Libraries/LibWeb/MimeSniff/Resource.cpp b/Userland/Libraries/LibWeb/MimeSniff/Resource.cpp index 150e4f8807..81bd906c0f 100644 --- a/Userland/Libraries/LibWeb/MimeSniff/Resource.cpp +++ b/Userland/Libraries/LibWeb/MimeSniff/Resource.cpp @@ -151,9 +151,9 @@ bool matches_mp4_signature(ReadonlyBytes sequence) // 4. Let box-size be the four bytes from sequence[0] to sequence[3], interpreted as a 32-bit unsigned big-endian integer. u32 box_size = 0; box_size |= static_cast(sequence[0] << 24); - box_size |= box_size + static_cast(sequence[1] << 16); - box_size |= box_size + static_cast(sequence[2] << 8); - box_size |= box_size + sequence[3]; + box_size |= static_cast(sequence[1] << 16); + box_size |= static_cast(sequence[2] << 8); + box_size |= sequence[3]; // 5. If length is less than box-size or if box-size modulo 4 is not equal to 0, return false. if ((length < box_size) || (box_size % 4 != 0))