mirror of
https://github.com/RGBCube/serenity
synced 2025-07-25 21:17:44 +00:00
LibJS: Remove GlobalObject from VM::throw_completion()
This is a continuation of the previous five commits. A first big step into the direction of no longer having to pass a realm (or currently, a global object) trough layers upon layers of AOs! Unlike the create() APIs we can safely assume that this is only ever called when a running execution context and therefore current realm exists. If not, you can always manually allocate the Error and put it in a Completion :^) In the spec, throw exceptions implicitly use the current realm's intrinsics as well: https://tc39.es/ecma262/#sec-throw-an-exception
This commit is contained in:
parent
5398dcc55e
commit
f3117d46dc
165 changed files with 892 additions and 900 deletions
|
@ -129,7 +129,7 @@ ThrowCompletionOr<void> DeclarativeEnvironment::set_mutable_binding(GlobalObject
|
|||
if (!index.has_value()) {
|
||||
// a. If S is true, throw a ReferenceError exception.
|
||||
if (strict)
|
||||
return vm().throw_completion<ReferenceError>(global_object, ErrorType::UnknownIdentifier, name);
|
||||
return vm().throw_completion<ReferenceError>(ErrorType::UnknownIdentifier, name);
|
||||
|
||||
// b. Perform ! envRec.CreateMutableBinding(N, true).
|
||||
MUST(create_mutable_binding(global_object, name, true));
|
||||
|
@ -148,20 +148,20 @@ ThrowCompletionOr<void> DeclarativeEnvironment::set_mutable_binding(GlobalObject
|
|||
return {};
|
||||
}
|
||||
|
||||
ThrowCompletionOr<void> DeclarativeEnvironment::set_mutable_binding_direct(GlobalObject& global_object, size_t index, Value value, bool strict)
|
||||
ThrowCompletionOr<void> DeclarativeEnvironment::set_mutable_binding_direct(GlobalObject&, size_t index, Value value, bool strict)
|
||||
{
|
||||
auto& binding = m_bindings[index];
|
||||
if (binding.strict)
|
||||
strict = true;
|
||||
|
||||
if (!binding.initialized)
|
||||
return vm().throw_completion<ReferenceError>(global_object, ErrorType::BindingNotInitialized, binding.name);
|
||||
return vm().throw_completion<ReferenceError>(ErrorType::BindingNotInitialized, binding.name);
|
||||
|
||||
if (binding.mutable_) {
|
||||
binding.value = value;
|
||||
} else {
|
||||
if (strict)
|
||||
return vm().throw_completion<TypeError>(global_object, ErrorType::InvalidAssignToConst);
|
||||
return vm().throw_completion<TypeError>(ErrorType::InvalidAssignToConst);
|
||||
}
|
||||
|
||||
return {};
|
||||
|
@ -178,13 +178,13 @@ ThrowCompletionOr<Value> DeclarativeEnvironment::get_binding_value(GlobalObject&
|
|||
return get_binding_value_direct(global_object, *index, strict);
|
||||
}
|
||||
|
||||
ThrowCompletionOr<Value> DeclarativeEnvironment::get_binding_value_direct(GlobalObject& global_object, size_t index, bool)
|
||||
ThrowCompletionOr<Value> DeclarativeEnvironment::get_binding_value_direct(GlobalObject&, size_t index, bool)
|
||||
{
|
||||
auto& binding = m_bindings[index];
|
||||
|
||||
// 2. If the binding for N in envRec is an uninitialized binding, throw a ReferenceError exception.
|
||||
if (!binding.initialized)
|
||||
return vm().throw_completion<ReferenceError>(global_object, ErrorType::BindingNotInitialized, binding.name);
|
||||
return vm().throw_completion<ReferenceError>(ErrorType::BindingNotInitialized, binding.name);
|
||||
|
||||
// 3. Return the value currently bound to N in envRec.
|
||||
return binding.value;
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue