RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-28 14:17:34 +00:00
Code Issues Activity Actions

LibGUI+Userland: Propagate errors in Model::column_name()

Browse source
This commit is contained in:
Sam Atkins 2023-06-13 16:30:15 +01:00 • committed by Andreas Kling
parent 94bcb5bea8
commit f33824d2e9
73 changed files with 140 additions and 146 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Applications/Browser/History/HistoryModel.cpp
View file

@ -34,7 +34,7 @@ int HistoryModel::row_count(GUI::ModelIndex const& index) const
return 0;
}
String HistoryModel::column_name(int column) const
ErrorOr<String> HistoryModel::column_name(int column) const
{
switch (column) {
case Column::Title:
@ -45,7 +45,7 @@ String HistoryModel::column_name(int column) const
VERIFY_NOT_REACHED();
}
return {};
return String {};
}
GUI::ModelIndex HistoryModel::index(int row, int column, GUI::ModelIndex const&) const

2
Userland/Applications/Browser/History/HistoryModel.h
View file

@ -25,7 +25,7 @@ public:
void clear_items();
virtual int row_count(GUI::ModelIndex const&) const override;
virtual int column_count(GUI::ModelIndex const& = GUI::ModelIndex()) const override { return Column::__Count; }
virtual String column_name(int column) const override;
virtual ErrorOr<String> column_name(int) const override;
virtual GUI::ModelIndex index(int row, int column = 0, GUI::ModelIndex const& = GUI::ModelIndex()) const override;
virtual GUI::Variant data(GUI::ModelIndex const& index, GUI::ModelRole role = GUI::ModelRole::Display) const override;
virtual GUI::Model::MatchResult data_matches(GUI::ModelIndex const& index, GUI::Variant const& term) const override;