RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 20:57:35 +00:00
Code Issues Activity Actions

LibGUI+Userland: Propagate errors in Model::column_name()

Browse source
This commit is contained in:
Sam Atkins 2023-06-13 16:30:15 +01:00 • committed by Andreas Kling
parent 94bcb5bea8
commit f33824d2e9
73 changed files with 140 additions and 146 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Applications/SoundPlayer/PlaylistWidget.cpp
View file

@ -73,13 +73,13 @@ DeprecatedString PlaylistModel::format_duration(u32 duration_in_seconds)
return DeprecatedString::formatted("{:02}:{:02}:{:02}", duration_in_seconds / 3600, duration_in_seconds / 60, duration_in_seconds % 60);
}
String PlaylistModel::column_name(int column) const
ErrorOr<String> PlaylistModel::column_name(int column) const
{
switch (column) {
case 0:
return "Title"_short_string;
case 1:
return "Duration"_string.release_value_but_fixme_should_propagate_errors();
return TRY("Duration"_string);
case 2:
return "Group"_short_string;
case 3:
@ -87,7 +87,7 @@ String PlaylistModel::column_name(int column) const
case 4:
return "Artist"_short_string;
case 5:
return "Filesize"_string.release_value_but_fixme_should_propagate_errors();
return TRY("Filesize"_string);
}
VERIFY_NOT_REACHED();
}

2
Userland/Applications/SoundPlayer/PlaylistWidget.h
View file

@ -24,7 +24,7 @@ public:
int row_count(const GUI::ModelIndex&) const override { return m_playlist_items.size(); }
int column_count(const GUI::ModelIndex&) const override { return 6; }
GUI::Variant data(const GUI::ModelIndex&, GUI::ModelRole) const override;
String column_name(int column) const override;
ErrorOr<String> column_name(int column) const override;
Vector<M3UEntry>& items() { return m_playlist_items; }
private: