RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 13:27:35 +00:00
Code Issues Activity Actions

LibGUI+Userland: Propagate errors in Model::column_name()

Browse source
This commit is contained in:
Sam Atkins 2023-06-13 16:30:15 +01:00 • committed by Andreas Kling
parent 94bcb5bea8
commit f33824d2e9
73 changed files with 140 additions and 146 deletions
Download patch file Download diff file Expand all files Collapse all files

9
Userland/DevTools/Profiler/ProfileModel.cpp
View file

@ -74,22 +74,21 @@ int ProfileModel::column_count(GUI::ModelIndex const&) const
return Column::__Count;
}
String ProfileModel::column_name(int column) const
ErrorOr<String> ProfileModel::column_name(int column) const
{
switch (column) {
case Column::SampleCount:
return m_profile.show_percentages() ? "% Samples"_string.release_value_but_fixme_should_propagate_errors() : "# Samples"_string.release_value_but_fixme_should_propagate_errors();
return m_profile.show_percentages() ? TRY("% Samples"_string) : TRY("# Samples"_string);
case Column::SelfCount:
return m_profile.show_percentages() ? "% Self"_short_string : "# Self"_short_string;
case Column::ObjectName:
return "Object"_short_string;
case Column::StackFrame:
return "Stack Frame"_string.release_value_but_fixme_should_propagate_errors();
return TRY("Stack Frame"_string);
case Column::SymbolAddress:
return "Symbol Address"_string.release_value_but_fixme_should_propagate_errors();
return TRY("Symbol Address"_string);
default:
VERIFY_NOT_REACHED();
return {};
}
}