RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-23 08:17:34 +00:00
Code Issues Activity Actions

LibWeb: Make sure the ICB is at least as tall as the viewport

Browse source 
This is a hack until we implement a proper overflow mechanism. For now,
this allows us to right-click below the lowest content on the page.
This commit is contained in:
Andreas Kling 2020-12-17 00:58:23 +01:00
parent 598efa60a3
commit f35f605a24
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Libraries/LibWeb/Layout/BlockFormattingContext.cpp
View file

@ -620,7 +620,9 @@ void BlockFormattingContext::layout_initial_containing_block(LayoutMode layout_m
icb.for_each_child_of_type<Box>([&](auto& child) { icb.for_each_child_of_type<Box>([&](auto& child) {
lowest_bottom = max(lowest_bottom, child.absolute_rect().bottom()); lowest_bottom = max(lowest_bottom, child.absolute_rect().bottom());
}); });
icb.set_height(lowest_bottom);
// FIXME: This is a hack and should be managed by an overflow mechanism.
icb.set_height(max(static_cast<float>(viewport_rect.height()), lowest_bottom));
// FIXME: This is a total hack. Make sure any GUI::Widgets are moved into place after layout. // FIXME: This is a total hack. Make sure any GUI::Widgets are moved into place after layout.
// We should stop embedding GUI::Widgets entirely, since that won't work out-of-process. // We should stop embedding GUI::Widgets entirely, since that won't work out-of-process.