RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-24 21:27:44 +00:00
Code Issues Activity Actions

LibJS: Inline bytecode ops for direct local/register access

Browse source 
These can do a lot less stuff if we put them directly in the interpreter
loop and allow them to access the locals/registers arrays directly.
This commit is contained in:
Andreas Kling 2023-09-27 10:31:07 +02:00
parent ae1ac9871b
commit f3606adc58
2 changed files with 33 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

33
Userland/Libraries/LibJS/Bytecode/Interpreter.cpp
View file

@ -178,6 +178,9 @@ ThrowCompletionOr<Value> Interpreter::run(SourceTextModule& module)
void Interpreter::run_bytecode() void Interpreter::run_bytecode()
{ {
auto* locals = vm().running_execution_context().local_variables.data();
auto* registers = this->registers().data();
auto& accumulator = this->accumulator();
for (;;) { for (;;) {
start: start:
auto pc = InstructionStreamIterator { m_current_block->instruction_stream(), m_current_executable }; auto pc = InstructionStreamIterator { m_current_block->instruction_stream(), m_current_executable };
@ -192,23 +195,45 @@ void Interpreter::run_bytecode()
auto& instruction = *pc; auto& instruction = *pc;
switch (instruction.type()) { switch (instruction.type()) {
case Instruction::Type::GetLocal: {
auto& local = locals[static_cast<Op::GetLocal const&>(instruction).index()];
if (local.is_empty()) {
auto const& variable_name = vm().running_execution_context().function->local_variables_names()[static_cast<Op::GetLocal const&>(instruction).index()];
result = vm().throw_completion<ReferenceError>(ErrorType::BindingNotInitialized, variable_name);
break;
}
accumulator = local;
break;
}
case Instruction::Type::SetLocal:
locals[static_cast<Op::SetLocal const&>(instruction).index()] = accumulator;
break;
case Instruction::Type::Load:
accumulator = registers[static_cast<Op::Load const&>(instruction).src().index()];
break;
case Instruction::Type::Store:
registers[static_cast<Op::Store const&>(instruction).dst().index()] = accumulator;
break;
case Instruction::Type::LoadImmediate:
accumulator = static_cast<Op::LoadImmediate const&>(instruction).value();
break;
case Instruction::Type::Jump: case Instruction::Type::Jump:
m_current_block = &static_cast<Op::Jump const&>(instruction).true_target()->block(); m_current_block = &static_cast<Op::Jump const&>(instruction).true_target()->block();
goto start; goto start;
case Instruction::Type::JumpConditional: case Instruction::Type::JumpConditional:
if (accumulator().to_boolean()) if (accumulator.to_boolean())
m_current_block = &static_cast<Op::Jump const&>(instruction).true_target()->block(); m_current_block = &static_cast<Op::Jump const&>(instruction).true_target()->block();
else else
m_current_block = &static_cast<Op::Jump const&>(instruction).false_target()->block(); m_current_block = &static_cast<Op::Jump const&>(instruction).false_target()->block();
goto start; goto start;
case Instruction::Type::JumpNullish: case Instruction::Type::JumpNullish:
if (accumulator().is_nullish()) if (accumulator.is_nullish())
m_current_block = &static_cast<Op::Jump const&>(instruction).true_target()->block(); m_current_block = &static_cast<Op::Jump const&>(instruction).true_target()->block();
else else
m_current_block = &static_cast<Op::Jump const&>(instruction).false_target()->block(); m_current_block = &static_cast<Op::Jump const&>(instruction).false_target()->block();
goto start; goto start;
case Instruction::Type::JumpUndefined: case Instruction::Type::JumpUndefined:
if (accumulator().is_undefined()) if (accumulator.is_undefined())
m_current_block = &static_cast<Op::Jump const&>(instruction).true_target()->block(); m_current_block = &static_cast<Op::Jump const&>(instruction).true_target()->block();
else else
m_current_block = &static_cast<Op::Jump const&>(instruction).false_target()->block(); m_current_block = &static_cast<Op::Jump const&>(instruction).false_target()->block();
@ -257,7 +282,7 @@ void Interpreter::run_bytecode()
m_current_block = unwind_context.handler; m_current_block = unwind_context.handler;
unwind_context.handler_called = true; unwind_context.handler_called = true;
accumulator() = reg(Register::exception()); accumulator = reg(Register::exception());
reg(Register::exception()) = {}; reg(Register::exception()) = {};
goto start; goto start;
} }

4
Userland/Libraries/LibJS/Bytecode/Op.h
View file

@ -40,6 +40,8 @@ public:
ThrowCompletionOr<void> execute_impl(Bytecode::Interpreter&) const; ThrowCompletionOr<void> execute_impl(Bytecode::Interpreter&) const;
DeprecatedString to_deprecated_string_impl(Bytecode::Executable const&) const; DeprecatedString to_deprecated_string_impl(Bytecode::Executable const&) const;
Register src() const { return m_src; }
private: private:
Register m_src; Register m_src;
}; };
@ -55,6 +57,8 @@ public:
ThrowCompletionOr<void> execute_impl(Bytecode::Interpreter&) const; ThrowCompletionOr<void> execute_impl(Bytecode::Interpreter&) const;
DeprecatedString to_deprecated_string_impl(Bytecode::Executable const&) const; DeprecatedString to_deprecated_string_impl(Bytecode::Executable const&) const;
Value value() const { return m_value; }
private: private:
Value m_value; Value m_value;
}; };