RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 18:17:44 +00:00
Code Issues Activity Actions

LibJS: Use consistent phrasing for string length

Browse source 
This is an editorial change in the ECMA-262 spec.

See: 33ea99e
This commit is contained in:
Linus Groh 2022-05-03 21:37:01 +02:00
parent 8b035b80d3
commit f3768705a9
2 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibJS/Runtime/GlobalObject.cpp
View file

@ -495,7 +495,7 @@ static ThrowCompletionOr<String> encode(GlobalObject& global_object, String cons
auto& vm = global_object.vm(); auto& vm = global_object.vm();
auto utf16_string = Utf16String(string); auto utf16_string = Utf16String(string);
// 1. Let strLen be the number of code units in string. // 1. Let strLen be the length of string.
auto string_length = utf16_string.length_in_code_units(); auto string_length = utf16_string.length_in_code_units();
// 2. Let R be the empty String. // 2. Let R be the empty String.

6
Userland/Libraries/LibJS/Runtime/RegExpPrototype.cpp
View file

@ -167,7 +167,7 @@ static ThrowCompletionOr<Value> regexp_builtin_exec(GlobalObject& global_object,
{ {
auto& vm = global_object.vm(); auto& vm = global_object.vm();
// 1. Let length be the number of code units in S. // 1. Let length be the length of S.
// 2. Let lastIndex be ℝ(? ToLength(? Get(R, "lastIndex"))). // 2. Let lastIndex be ℝ(? ToLength(? Get(R, "lastIndex"))).
auto last_index_value = TRY(regexp_object.get(vm.names.lastIndex)); auto last_index_value = TRY(regexp_object.get(vm.names.lastIndex));
auto last_index = TRY(last_index_value.to_length(global_object)); auto last_index = TRY(last_index_value.to_length(global_object));
@ -391,7 +391,7 @@ size_t advance_string_index(Utf16View const& string, size_t index, bool unicode)
if (!unicode) if (!unicode)
return index + 1; return index + 1;
// 3. Let length be the number of code units in S. // 3. Let length be the length of S.
// 4. If index + 1 ≥ length, return index + 1. // 4. If index + 1 ≥ length, return index + 1.
if (index + 1 >= string.length_in_code_units()) if (index + 1 >= string.length_in_code_units())
return index + 1; return index + 1;
@ -681,7 +681,7 @@ JS_DEFINE_NATIVE_FUNCTION(RegExpPrototype::symbol_replace)
auto matched_value = TRY(result.get(global_object, 0)); auto matched_value = TRY(result.get(global_object, 0));
auto matched = TRY(matched_value.to_utf16_string(global_object)); auto matched = TRY(matched_value.to_utf16_string(global_object));
// d. Let matchLength be the number of code units in matched. // d. Let matchLength be the length of matched.
auto matched_length = matched.length_in_code_units(); auto matched_length = matched.length_in_code_units();
// e. Let position be ? ToIntegerOrInfinity(? Get(result, "index")). // e. Let position be ? ToIntegerOrInfinity(? Get(result, "index")).