mirror of
https://github.com/RGBCube/serenity
synced 2025-07-25 19:27:44 +00:00
LibGfx+Everywhere: Change Gfx::Rect
to be endpoint exclusive
Previously, calling `.right()` on a `Gfx::Rect` would return the last column's coordinate still inside the rectangle, or `left + width - 1`. This is called 'endpoint inclusive' and does not make a lot of sense for `Gfx::Rect<float>` where a rectangle of width 5 at position (0, 0) would return 4 as its right side. This same problem exists for `.bottom()`. This changes `Gfx::Rect` to be endpoint exclusive, which gives us the nice property that `width = right - left` and `height = bottom - top`. It enables us to treat `Gfx::Rect<int>` and `Gfx::Rect<float>` exactly the same. All users of `Gfx::Rect` have been updated accordingly.
This commit is contained in:
parent
b7f4363791
commit
f391ccfe53
88 changed files with 524 additions and 518 deletions
|
@ -43,7 +43,7 @@ protected:
|
|||
void paint_event(GUI::PaintEvent&) override;
|
||||
void draw_face(GUI::Painter&);
|
||||
void draw_mirrored_graduations(GUI::Painter&, Gfx::IntRect&, int x, int y, int rect_center_offset);
|
||||
void draw_graduations(GUI::Painter&, Gfx::IntRect&, int x, int y);
|
||||
void draw_graduations(GUI::Painter&, Gfx::IntRect, int x, int y);
|
||||
void draw_hand(GUI::Painter&, double angle, double length, Gfx::Color hand_color);
|
||||
void draw_seconds_hand(GUI::Painter&, double angle);
|
||||
void update_title_date();
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue