mirror of
https://github.com/RGBCube/serenity
synced 2025-07-25 02:57:42 +00:00
LibGfx+Everywhere: Change Gfx::Rect
to be endpoint exclusive
Previously, calling `.right()` on a `Gfx::Rect` would return the last column's coordinate still inside the rectangle, or `left + width - 1`. This is called 'endpoint inclusive' and does not make a lot of sense for `Gfx::Rect<float>` where a rectangle of width 5 at position (0, 0) would return 4 as its right side. This same problem exists for `.bottom()`. This changes `Gfx::Rect` to be endpoint exclusive, which gives us the nice property that `width = right - left` and `height = bottom - top`. It enables us to treat `Gfx::Rect<int>` and `Gfx::Rect<float>` exactly the same. All users of `Gfx::Rect` have been updated accordingly.
This commit is contained in:
parent
b7f4363791
commit
f391ccfe53
88 changed files with 524 additions and 518 deletions
|
@ -117,11 +117,11 @@ void MagnifierWidget::paint_event(GUI::PaintEvent& event)
|
|||
int end_y = bitmap_rect.bottom();
|
||||
int end_x = bitmap_rect.right();
|
||||
|
||||
for (int current_y = start_y; current_y <= end_y; current_y += m_scale_factor)
|
||||
painter.draw_line({ start_x, current_y }, { end_x, current_y }, m_grid_color);
|
||||
for (int current_y = start_y; current_y < end_y; current_y += m_scale_factor)
|
||||
painter.draw_line({ start_x, current_y }, { end_x - 1, current_y }, m_grid_color);
|
||||
|
||||
for (int current_x = start_y; current_x <= end_x; current_x += m_scale_factor)
|
||||
painter.draw_line({ current_x, start_y }, { current_x, end_y }, m_grid_color);
|
||||
for (int current_x = start_y; current_x < end_x; current_x += m_scale_factor)
|
||||
painter.draw_line({ current_x, start_y }, { current_x, end_y - 1 }, m_grid_color);
|
||||
}
|
||||
}
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue