mirror of
https://github.com/RGBCube/serenity
synced 2025-07-25 02:27:35 +00:00
LibGfx+Everywhere: Change Gfx::Rect
to be endpoint exclusive
Previously, calling `.right()` on a `Gfx::Rect` would return the last column's coordinate still inside the rectangle, or `left + width - 1`. This is called 'endpoint inclusive' and does not make a lot of sense for `Gfx::Rect<float>` where a rectangle of width 5 at position (0, 0) would return 4 as its right side. This same problem exists for `.bottom()`. This changes `Gfx::Rect` to be endpoint exclusive, which gives us the nice property that `width = right - left` and `height = bottom - top`. It enables us to treat `Gfx::Rect<int>` and `Gfx::Rect<float>` exactly the same. All users of `Gfx::Rect` have been updated accordingly.
This commit is contained in:
parent
b7f4363791
commit
f391ccfe53
88 changed files with 524 additions and 518 deletions
|
@ -48,9 +48,9 @@ public:
|
|||
{
|
||||
set_view(
|
||||
rect.left() * (m_x_end - m_x_start) / m_bitmap->width() + m_x_start,
|
||||
rect.right() * (m_x_end - m_x_start) / m_bitmap->width() + m_x_start,
|
||||
(rect.right() - 1) * (m_x_end - m_x_start) / m_bitmap->width() + m_x_start,
|
||||
rect.top() * (m_y_end - m_y_start) / m_bitmap->height() + m_y_start,
|
||||
rect.bottom() * (m_y_end - m_y_start) / m_bitmap->height() + m_y_start);
|
||||
(rect.bottom() - 1) * (m_y_end - m_y_start) / m_bitmap->height() + m_y_start);
|
||||
correct_aspect();
|
||||
calculate();
|
||||
}
|
||||
|
@ -146,8 +146,8 @@ public:
|
|||
if (rect.is_empty())
|
||||
return;
|
||||
|
||||
for (int py = rect.top(); py <= rect.bottom(); py++)
|
||||
for (int px = rect.left(); px <= rect.right(); px++)
|
||||
for (int py = rect.top(); py < rect.bottom(); py++)
|
||||
for (int px = rect.left(); px < rect.right(); px++)
|
||||
calculate_pixel(px, py, max_iterations);
|
||||
}
|
||||
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue