mirror of
				https://github.com/RGBCube/serenity
				synced 2025-10-31 19:22:45 +00:00 
			
		
		
		
	LibGfx+Everywhere: Change Gfx::Rect to be endpoint exclusive
				
					
				
			Previously, calling `.right()` on a `Gfx::Rect` would return the last column's coordinate still inside the rectangle, or `left + width - 1`. This is called 'endpoint inclusive' and does not make a lot of sense for `Gfx::Rect<float>` where a rectangle of width 5 at position (0, 0) would return 4 as its right side. This same problem exists for `.bottom()`. This changes `Gfx::Rect` to be endpoint exclusive, which gives us the nice property that `width = right - left` and `height = bottom - top`. It enables us to treat `Gfx::Rect<int>` and `Gfx::Rect<float>` exactly the same. All users of `Gfx::Rect` have been updated accordingly.
This commit is contained in:
		
							parent
							
								
									b7f4363791
								
							
						
					
					
						commit
						f391ccfe53
					
				
					 88 changed files with 524 additions and 518 deletions
				
			
		|  | @ -42,7 +42,7 @@ void TimelineHeader::paint_event(GUI::PaintEvent& event) | |||
|         painter.blit(icon_rect.location(), *m_icon, m_icon->rect()); | ||||
| 
 | ||||
|     Gfx::IntRect text_rect { | ||||
|         icon_rect.right() + 6, | ||||
|         icon_rect.right() + 5, | ||||
|         icon_rect.y(), | ||||
|         width() - 32, | ||||
|         32 | ||||
|  |  | |||
		Loading…
	
	Add table
		Add a link
		
	
		Reference in a new issue
	
	 Jelle Raaijmakers
						Jelle Raaijmakers