mirror of
https://github.com/RGBCube/serenity
synced 2025-07-25 06:37:43 +00:00
LibGfx+Everywhere: Change Gfx::Rect
to be endpoint exclusive
Previously, calling `.right()` on a `Gfx::Rect` would return the last column's coordinate still inside the rectangle, or `left + width - 1`. This is called 'endpoint inclusive' and does not make a lot of sense for `Gfx::Rect<float>` where a rectangle of width 5 at position (0, 0) would return 4 as its right side. This same problem exists for `.bottom()`. This changes `Gfx::Rect` to be endpoint exclusive, which gives us the nice property that `width = right - left` and `height = bottom - top`. It enables us to treat `Gfx::Rect<int>` and `Gfx::Rect<float>` exactly the same. All users of `Gfx::Rect` have been updated accordingly.
This commit is contained in:
parent
b7f4363791
commit
f391ccfe53
88 changed files with 524 additions and 518 deletions
|
@ -204,9 +204,9 @@ template<>
|
|||
FloatRect AffineTransform::map(FloatRect const& rect) const
|
||||
{
|
||||
FloatPoint p1 = map(rect.top_left());
|
||||
FloatPoint p2 = map(rect.top_right().translated(1, 0));
|
||||
FloatPoint p3 = map(rect.bottom_right().translated(1, 1));
|
||||
FloatPoint p4 = map(rect.bottom_left().translated(0, 1));
|
||||
FloatPoint p2 = map(rect.top_right());
|
||||
FloatPoint p3 = map(rect.bottom_right());
|
||||
FloatPoint p4 = map(rect.bottom_left());
|
||||
float left = smallest_of(p1.x(), p2.x(), p3.x(), p4.x());
|
||||
float top = smallest_of(p1.y(), p2.y(), p3.y(), p4.y());
|
||||
float right = largest_of(p1.x(), p2.x(), p3.x(), p4.x());
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue