mirror of
https://github.com/RGBCube/serenity
synced 2025-07-25 05:07:34 +00:00
LibGfx+Everywhere: Change Gfx::Rect
to be endpoint exclusive
Previously, calling `.right()` on a `Gfx::Rect` would return the last column's coordinate still inside the rectangle, or `left + width - 1`. This is called 'endpoint inclusive' and does not make a lot of sense for `Gfx::Rect<float>` where a rectangle of width 5 at position (0, 0) would return 4 as its right side. This same problem exists for `.bottom()`. This changes `Gfx::Rect` to be endpoint exclusive, which gives us the nice property that `width = right - left` and `height = bottom - top`. It enables us to treat `Gfx::Rect<int>` and `Gfx::Rect<float>` exactly the same. All users of `Gfx::Rect` have been updated accordingly.
This commit is contained in:
parent
b7f4363791
commit
f391ccfe53
88 changed files with 524 additions and 518 deletions
|
@ -219,7 +219,7 @@ void ClockWidget::position_calendar_window()
|
|||
{
|
||||
constexpr auto taskbar_top_padding { 4 };
|
||||
m_calendar_window->set_rect(
|
||||
screen_relative_rect().right() - m_calendar_window->width() + 1,
|
||||
screen_relative_rect().right() - m_calendar_window->width(),
|
||||
screen_relative_rect().top() - taskbar_top_padding - m_calendar_window->height(),
|
||||
m_window_size.width(),
|
||||
m_window_size.height());
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue