RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 07:28:11 +00:00
Code Issues Activity Actions

Kernel: Remove two bad FIXME's

Browse source 
We should absolutely *not* create a new thread in sys$exec().
There's also no sys$spawn() anymore.
This commit is contained in:
Andreas Kling 2020-02-08 00:02:35 +01:00
parent 71ca7ba31f
commit f3a5985bb2
1 changed files with 0 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Kernel/Process.cpp
View file

@ -927,7 +927,6 @@ int Process::do_exec(NonnullRefPtr<FileDescription> main_program_description, Ve
}
}
// FIXME: Should we just make a new Thread here instead?
Thread* new_main_thread = nullptr;
if (&current->process() == this) {
new_main_thread = current;
@ -1220,7 +1219,6 @@ int Process::sys$execve(const Syscall::SC_execve_params* user_params)
Process* Process::create_user_process(Thread*& first_thread, const String& path, uid_t uid, gid_t gid, pid_t parent_pid, int& error, Vector<String>&& arguments, Vector<String>&& environment, TTY* tty)
{
// FIXME: Don't split() the path twice (sys$spawn also does it...)
auto parts = path.split('/');
if (arguments.is_empty()) {
arguments.append(parts.last());