RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 19:37:36 +00:00
Code Issues Activity Actions

WebDriver: Include (empty) capabilities object in /session POST response

Browse source 
Still not spec compliant, but at least we now return both assumed values
of the JSON object ("sessionId", "capabilities").
This commit is contained in:
Linus Groh 2022-10-18 22:29:18 +02:00
parent dd4e5d5028
commit f3d66b1108
1 changed files with 6 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Services/WebDriver/Client.cpp
View file

@ -338,6 +338,7 @@ ErrorOr<JsonValue, HttpError> Client::handle_new_session(Vector<StringView> cons
// return error with error code session not created. // return error with error code session not created.
// FIXME: 4. Let capabilities be the result of trying to process capabilities with parameters as an argument. // FIXME: 4. Let capabilities be the result of trying to process capabilities with parameters as an argument.
auto capabilities = JsonObject {};
// FIXME: 5. If capabilities’s is null, return error with error code session not created. // FIXME: 5. If capabilities’s is null, return error with error code session not created.
@ -362,11 +363,12 @@ ErrorOr<JsonValue, HttpError> Client::handle_new_session(Vector<StringView> cons
// 11. Let body be a JSON Object initialized with: // 11. Let body be a JSON Object initialized with:
JsonObject body; JsonObject body;
// "sessionId" // "sessionId"
// session id // session id
body.set("sessionId", String::number(session_id)); body.set("sessionId", String::number(session_id));
// FIXME: "capabilities" // "capabilities"
// capabilities // capabilities
body.set("capabilities", move(capabilities));
// FIXME: 12. Initialize the following from capabilities: // FIXME: 12. Initialize the following from capabilities:
// NOTE: See spec for steps // NOTE: See spec for steps