RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 21:47:46 +00:00
Code Issues Activity Actions

LibWeb: Use correct variable when handling slottables in node insertion

Browse source 
Errantly copied the variable name from the spec. The `node` variable in
this scope is what we passed to Node::insert_before; `node_to_insert` is
what the spec is actually referring to as `node` here.
This commit is contained in:
Timothy Flynn 2023-11-03 14:22:09 -04:00 • committed by Andreas Kling
parent 58e2fe895c
commit f3e14d7f64
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibWeb/DOM/Node.cpp
View file

@ -456,8 +456,8 @@ void Node::insert_before(JS::NonnullGCPtr<Node> node, JS::GCPtr<Node> child, boo
auto is_named_shadow_host = element.is_shadow_host()
&& element.shadow_root_internal()->slot_assignment() == Bindings::SlotAssignmentMode::Named;
if (is_named_shadow_host && node->is_slottable())
assign_a_slot(node->as_slottable());
if (is_named_shadow_host && node_to_insert->is_slottable())
assign_a_slot(node_to_insert->as_slottable());
}
// 5. If parent’s root is a shadow root, and parent is a slot whose assigned nodes is the empty list, then run
@ -470,7 +470,7 @@ void Node::insert_before(JS::NonnullGCPtr<Node> node, JS::GCPtr<Node> child, boo
}
// 6. Run assign slottables for a tree with node’s root.
assign_slottables_for_a_tree(node->root());
assign_slottables_for_a_tree(node_to_insert->root());
node_to_insert->invalidate_style();