RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 19:37:36 +00:00
Code Issues Activity Actions

LibSQL: Avoid implicitly copying ByteBuffer

Browse source
This commit is contained in:
Ben Wiederhake 2021-11-28 22:13:28 +01:00 • committed by Brian Gianforcaro
parent f59f7674c8
commit f3e496d995
1 changed files with 2 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Userland/Libraries/LibSQL/Heap.cpp
View file

@ -72,7 +72,7 @@ ErrorOr<ByteBuffer> Heap::read_block(u32 block)
} }
auto buffer_or_empty = m_write_ahead_log.get(block); auto buffer_or_empty = m_write_ahead_log.get(block);
if (buffer_or_empty.has_value()) if (buffer_or_empty.has_value())
return buffer_or_empty.value(); return buffer_or_empty.release_value();
if (block >= m_next_block) { if (block >= m_next_block) {
warnln("Heap({})::read_block({}): block # out of range (>= {})"sv, name(), block, m_next_block); warnln("Heap({})::read_block({}): block # out of range (>= {})"sv, name(), block, m_next_block);
@ -203,10 +203,7 @@ constexpr static int USER_VALUES_OFFSET = 32;
ErrorOr<void> Heap::read_zero_block() ErrorOr<void> Heap::read_zero_block()
{ {
auto bytes_or_error = read_block(0); auto buffer = TRY(read_block(0));
if (bytes_or_error.is_error())
return bytes_or_error.error();
auto buffer = bytes_or_error.value();
auto file_id_buffer = buffer.slice(0, FILE_ID.length()); auto file_id_buffer = buffer.slice(0, FILE_ID.length());
auto file_id = StringView(file_id_buffer); auto file_id = StringView(file_id_buffer);
if (file_id != FILE_ID) { if (file_id != FILE_ID) {